-
Notifications
You must be signed in to change notification settings - Fork 725
[WIP][GUI] Include MN Rewards in the dashboard chart. #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][GUI] Include MN Rewards in the dashboard chart. #1362
Conversation
* zPIV chart data was replaced for the MN rewards (we don't have zPIV staking anymore). * txArrived signal is now notifying if a MN rewards was received.
|
needs rebase |
|
I have something similar if we want to compare how I have it done to record masternode and stakes in charts. Line 137 in dashboardwidget.cpp Maybe collaborate on finishing this up with you. A quick cleanup changing the ZPiv used titles and calculations would suffice mostly for this instance Are you keeping the ZPiv for the 5.0 update? I see adding some options like fShowZpivStakes I am sure you have a better logic behind yours vs mine but I can help here. |
|
Hello. I left it under WIP for performance concerns over big controller wallets. We need to improve the tx filter used in the chart before include another set of data income there. |
|
Hi @furszy, we already have this feature implemented, and we can share it with you. |
|
Hey hello @decenomy, a bit of context here: Now.. standing in v5.2 and after all the changes that did for v5.xx (#2203, #2082, #2118, #2150, #2192, #2195, etc etc) the overall software responsiveness is in a much better state to get this one rebased and merged. But.. there is one more task that will be nice do to before moving forward with this feature. |
|
superseded by #2577. Closing. |
efc2198 GUI: dashboard chart, drop zPIV naming for MN rewards. (furszy) 222a511 GUI: Clean duplicate and unneeded tx filter options. (furszy) Pull request description: Revival of #1362 with further cleanup. As we don't have zPIV anymore, this PR removes it from the dashboard chart and include the Masternodes rewards instead. ACKs for top commit: random-zebra: re-ACK efc2198 Fuzzbawls: ACK efc2198 Tree-SHA512: 5280bb23e5480f773f11ccb265d7e48e0d85af53da4b37cbdd1439c5029c522bd6b322afc46cd8e44dfa187d157a8c975f7988b66ae1ffac7a59a0edbce0257b
Describing this work briefly:
As we don't have zPIV staking anymore, this PR removes it from the dashboard chart and includes the Masternodes rewards instead.
It was coded on top of #1361 (first commit doesn't count and we need to merge that PR first).
TODO:
Rename variable names from zpiv-something to MN instead in the dashboard file.