Skip to content

Conversation

@furszy
Copy link

@furszy furszy commented Feb 27, 2020

Describing this work briefly:
As we don't have zPIV staking anymore, this PR removes it from the dashboard chart and includes the Masternodes rewards instead.

It was coded on top of #1361 (first commit doesn't count and we need to merge that PR first).

TODO:
Rename variable names from zpiv-something to MN instead in the dashboard file.

* zPIV chart data was replaced for the MN rewards (we don't have zPIV staking anymore).
* txArrived signal is now notifying if a MN rewards was received.
@furszy furszy self-assigned this Feb 27, 2020
@Fuzzbawls Fuzzbawls added this to the 4.1.0 milestone Mar 4, 2020
@Fuzzbawls
Copy link
Collaborator

needs rebase

@Liquid369
Copy link
Member

I have something similar if we want to compare how I have it done to record masternode and stakes in charts.
I noticed you inserted MNReward tags for some but put in ZPiv for others than PIV. Trivial changes ie;

Line 137 in dashboardwidget.cpp
this->fShowZpivStakes = fIncludeZPIV;
this->fIncludeMNReward = fIncludeMNReward;

Maybe collaborate on finishing this up with you.
Had worked on this previously with @akshaynexus

A quick cleanup changing the ZPiv used titles and calculations would suffice mostly for this instance

Are you keeping the ZPiv for the 5.0 update?

I see adding some options like fShowZpivStakes

I am sure you have a better logic behind yours vs mine but I can help here.

@furszy
Copy link
Author

furszy commented Mar 29, 2020

Hello.
The object names can be easily be changed, not really a concern for now.

I left it under WIP for performance concerns over big controller wallets. We need to improve the tx filter used in the chart before include another set of data income there.

@furszy furszy modified the milestones: 4.1.0, Future Apr 6, 2020
@random-zebra random-zebra modified the milestones: Future, 5.0.0 Apr 24, 2020
@furszy furszy modified the milestones: 4.2.0, 5.0.0 Jun 29, 2020
@random-zebra random-zebra modified the milestones: 5.0.0, Future Oct 20, 2020
@Fuzzbawls Fuzzbawls marked this pull request as draft December 16, 2020 22:39
@decenomy
Copy link

Hi @furszy, we already have this feature implemented, and we can share it with you.

@furszy
Copy link
Author

furszy commented Jul 13, 2021

Hey hello @decenomy, a bit of context here:
I left this feature in stand-by not because it's difficult to implement, because when i did it, the 4.xx version of our software wasn't performant, and stable, enough in the GUI area and the MNs rewards inclusion in the chart filter was being perjudicial for the overall software experience.

Now.. standing in v5.2 and after all the changes that did for v5.xx (#2203, #2082, #2118, #2150, #2192, #2195, etc etc) the overall software responsiveness is in a much better state to get this one rebased and merged. But.. there is one more task that will be nice do to before moving forward with this feature.
Need to replace/rework the QT filter that is currently being used in the chart load (which essentially recalculates the entire chart presented information on every refresh) for one customly made with a cache system and signal based update (this will solve a current segfault, inside the QT filter class, that use to happen on large wallets during sync).

@furszy
Copy link
Author

furszy commented Oct 3, 2021

superseded by #2577. Closing.

@furszy furszy closed this Oct 3, 2021
Fuzzbawls added a commit that referenced this pull request Nov 23, 2021
efc2198 GUI: dashboard chart, drop zPIV naming for MN rewards. (furszy)
222a511 GUI: Clean duplicate and unneeded tx filter options. (furszy)

Pull request description:

  Revival of #1362 with further cleanup.

  As we don't have zPIV anymore, this PR removes it from the dashboard chart and include the Masternodes rewards instead.

ACKs for top commit:
  random-zebra:
    re-ACK efc2198
  Fuzzbawls:
    ACK efc2198

Tree-SHA512: 5280bb23e5480f773f11ccb265d7e48e0d85af53da4b37cbdd1439c5029c522bd6b322afc46cd8e44dfa187d157a8c975f7988b66ae1ffac7a59a0edbce0257b
@furszy furszy deleted the 2020_zpiv_chart_removed_for_mn_rewards branch November 29, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants