[Refactor] Move zerocoin checks out of main #1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
force-pushed
the
2020_move-zerocoin-checks
branch
2 times, most recently
from
69d541c to
a7ea3a9
Compare
Fuzzbawls
force-pushed
the
2020_move-zerocoin-checks
branch
from
a7ea3a9 to
15d8f3f
Compare
furszy
previously approved these changes
Feb 24, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Side from the minor object type change, utACK 15d8f3f.
This moves all zerocoin checking methods out of main.cpp/h into two new files in the `consensus` subdir: zerocoin_verify.cpp/h
Fuzzbawls
force-pushed
the
2020_move-zerocoin-checks
branch
from
15d8f3f to
bd49362
Compare
Collaborator
Author
|
rebased |
furszy
approved these changes
Feb 25, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is the final part of breaking up #1209 into individual narrow-focused PRs. For this one, the original commit had too many merge conflicts, so it was easier/faster for me to just start from a clean slate and re-do the commit. (reference branch is at https://github.com/Fuzzbawls/PIVX/commits/pr-1209)
Reference Commit:
Fuzzbawls@547ca6c
This moves all zerocoin checking methods out of main.cpp/h into two new
files in the
consensussubdir: zerocoin_verify.cpp/h