[zPIV][Cleanup] Zerocoin Cleanup 4: further wallet cleaning #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
needs rebase |
random-zebra
force-pushed
the
2020_Remove_Zerocoin_4
branch
2 times, most recently
from
d0216c2 to
5a6bbcb
Compare
Author
|
Rebased, and reduced to the first 4 commits only, to keep the PR more atomic. |
Removed extra imports in wallet.cpp Zerocoin implementation moved to wallet_zerocoin.cpp Only code move, no functional changes.
random-zebra
force-pushed
the
2020_Remove_Zerocoin_4
branch
from
5a6bbcb to
aa186cf
Compare
random-zebra
changed the title
random-zebra
force-pushed
the
2020_Remove_Zerocoin_4
branch
from
aa186cf to
79dccae
Compare
furszy
approved these changes
Feb 6, 2020
Fuzzbawls
approved these changes
Feb 7, 2020
|
And merging.. |
furszy
added a commit
that referenced
this pull request
Feb 7, 2020
79dccae [Trivial][RPC] Fix spendzerocoin num of arguments (random-zebra) c9aefbf [Doc] Update rel notes: remove zPIV backup - mintchange/minimizechange (random-zebra) 35dae21 [Cleanup][Trivial] Remove unused variable nStakeSetUpdateTime in wallet (random-zebra) f95af41 [Wallet][Cleanup] Refactor zPIV legacy functions at the end of wallet.* (random-zebra) 565b963 [Wallet][RPC] Remove fMintChange / fMinimizeChange from zc spends/mints (random-zebra) 76b7386 [Wallet][zPIV] Remove auto-backups. Lock minting only for tests. (random-zebra) Pull request description: Builds on top of #1293 . This removes zerocoin backups and locks minting only for tests. Mints and v2 spends are rejected from mempool. Removes `fMintChange/fMinimizeChange` options from RPC functions. Cleans up unused variables and functions. Zerocoin specific implementations have been moved from wallet.cpp to a new file wallet_zerocoin.cpp in the wallet directory. ACKs for top commit: furszy: cool refactor, utACK 79dccae. Fuzzbawls: ACK 79dccae Tree-SHA512: bb69e9e79e2a5664d351fdce1a35a16642576290ead7198e74b04213b478a5e1e9a96ff9aa800ca714c5c6f2045e780a533921681d2ab79af6761a8acebec7c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #1293 .
This removes zerocoin backups and locks minting only for tests. Mints and v2 spends are rejected from mempool. Removes
fMintChange/fMinimizeChangeoptions from RPC functions. Cleans up unused variables and functions. Zerocoin specific implementations have been moved from wallet.cpp to a new file wallet_zerocoin.cpp in the wallet directory.