[Wallet] Add function CMerkleTx::IsInMainChainImmature #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
2020_IsInMainChainImmature
branch
4 times, most recently
from
734dadc to
0f26b48
Compare
To avoid two consecutive calls to GetDepthInMainChain
random-zebra
force-pushed
the
2020_IsInMainChainImmature
branch
from
0f26b48 to
b32e418
Compare
furszy
approved these changes
Jan 28, 2020
furszy
added a commit
that referenced
this pull request
Feb 4, 2020
b32e418 [Wallet] Add function CMerkleTx::IsInMainChainImmature (random-zebra) Pull request description: This introduces a little performance optimization, removing the double call to `GetDepthInMainChain` (ref: #1281 (comment)). Note: in a successive PR we should review the LOCKs in this area of the wallet. ACKs for top commit: furszy: utACK b32e418 Tree-SHA512: 69e16557dd67e0450b3b9a14a3a182be39bdfcec8ef5a49ca156d9511cd9a7a532c650ed8440b147795dc3d003d10f1c8c737d0990db6365cdada2eb66997892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a little performance optimization, removing the double call to
GetDepthInMainChain(ref: #1281 (comment)).Note: in a successive PR we should review the LOCKs in this area of the wallet.