[Tests] Set '-staking' disabled by default on RegTest #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
2020_Tests_staking-flag
branch
2 times, most recently
from
9ff9763 to
479f95a
Compare
Fuzzbawls
previously approved these changes
Jan 26, 2020
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK 479f95a235a80dd10517d8cf1b44f268aa742d21
furszy
reviewed
Jan 26, 2020
random-zebra
force-pushed
the
2020_Tests_staking-flag
branch
from
479f95a to
9575319
Compare
Author
|
Fixed styling as per @furszy 's comment. /Squashed. |
Fuzzbawls
approved these changes
Jan 27, 2020
furszy
approved these changes
Jan 27, 2020
furszy
added a commit
that referenced
this pull request
Jan 27, 2020
9575319 [Tests] Set '-staking' disabled by default on RegTest (random-zebra) Pull request description: Ref: #1278 (comment) Hardcoded default `false` value, instead of having it in the config file for the test nodes. ACKs for top commit: Fuzzbawls: ACK 9575319 furszy: ACK 9575319 Tree-SHA512: 609f4eee57ab9e32a03a88cf014c407348d89f89bbaf6f56187a1bf20e458b7c83d76220f8c047427cd7319cf8ad4b6ff71a4aca06c51b71c6a3ab56efa7cf88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1278 (comment)
Hardcoded default
falsevalue, instead of having it in the config file for the test nodes.