[Backport] 4.0.2 backports #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: PIVX-Project#1261 Rebased-From: 814e510
Fixes a comparator bug when loading the initial `walletTxes` vector. The design intention is to load the 20k most recent transactions, but it was loading the first 20k transactions in error, resulting in a potentially large gap in the UI's transaction history. Github-Pull: PIVX-Project#1267 Rebased-From: ec72107
…onSent distinction. * P2CSDelegationSentOwner: Is the wallet who delegated the coins and kept the ownership. * P2CSDelegationSent: Is the wallet who delegated the coins and transferred the coin's ownership to a remote address. Github-Pull: PIVX-Project#1263 Rebased-From: 94f78fa
Github-Pull: PIVX-Project#1266 Rebased-From: 80e1531
Github-Pull: PIVX-Project#1266 Rebased-From: 7c524b9
Github-Pull: PIVX-Project#1264 Rebased-From: 4789652
…y showed label + inform snackbar notifying the user. Github-Pull: PIVX-Project#1269 Rebased-From: e3dd115
… clipboard texts. Github-Pull: PIVX-Project#1269 Rebased-From: c919f0e
Github-Pull: PIVX-Project#1265 Rebased-From: 4b24380
Github-Pull: PIVX-Project#1268 Rebased-From: 84b4ae4
Add a new checkpoint for the first v7 block for both mainnet and testnet Github-Pull: PIVX-Project#1273 Rebased-From: 793b0af
Github-Pull: PIVX-Project#1272 Rebased-From: 9952616
Github-Pull: PIVX-Project#1274 Rebased-From: 6b5ce00
1) Cold stakes status was not set properly, there was no immaturity or "xxx blocks to mature" calculated. 2) GetCredit method in P2CS in wallets with both private keys is returning the real credit amount doubled because of be summing the cold staking credit and the delegated credit of the exact same utxo. Quick fix to solve it, only request one of them.. not the final solution. Github-Pull: PIVX-Project#1279 Rebased-From: e6fc91a
furszy
approved these changes
Jan 16, 2020
furszy
added a commit
that referenced
this pull request
Jan 16, 2020
4663310 [GUI] Min window size (furszy) 5c76d51 Doc: Update manpages for 4.0.2 (Fuzzbawls) 79bfec9 Build: Bump version to 4.0.2 (Fuzzbawls) 82d0af7 Doc: Update release notes for 4.0.2 (Fuzzbawls) 3432e29 [GUI] Transaction record cold staking fixes. (furszy) e5badbc [RPC] Don't do extra PoW round for pos blocks in 'generate' RPC Github-Pull: #1274 Rebased-From: 6b5ce00 (random-zebra) 7b8169c [Trivial] Update copyright headers for 4.0.2 (Fuzzbawls) 8faf4bf [Core] Update checkpoints for first v7 block (Fuzzbawls) f6e8a14 [GUI] Add latest block number to topbar pushButtonSync Github-Pull: #1268 Rebased-From: 84b4ae4 (random-zebra) 8edfa83 [GUI] Connect P2CSUnlockOwner and P2CSUnlockStaker records to the model Github-Pull: #1265 Rebased-From: 4b24380 (random-zebra) e475827 [GUI] CoinControlDialog, removing extra spacing char from the copy to clipboard texts. (furszy) dbe2b3a [GUI] CoinControlDialog, copy to clipboard action implemented on every showed label + inform snackbar notifying the user. (furszy) 3404bd9 [Wallet] Don't add P2CS automatically to CWalletTx::GetLockedCredit Github-Pull: #1264 Rebased-From: 4789652 (random-zebra) d1f5731 [GUI] Force NavMenu to show dashboard button at startup. (furszy) cdee261 [GUI] Open the app's window in the smallest, currently available, size. (furszy) fc766c8 [GUI] TransactionRecord type P2CSDelegationSentOwner and P2CSDelegationSent distinction. (furszy) 49de2e4 [Qt][Bug] Load the most recent instead of the first transactions (Fuzzbawls) 827ca3e [Bug][GUI] Double counted delegated balance fix. (furszy) Pull request description: Updates the `4.0` branch with relevant merged PRs in preparation for tagging the `4.0.2` release. Included PRs: #1261 #1267 #1263 #1266 #1264 #1269 #1265 #1268 #1273 #1272 #1274 #1279 Top commit has no ACKs. Tree-SHA512: 561d9319d08756c040751c6ce145505610ed2ebc4351a87d9d3bb05ecb98df9f35d492e9e3eb7e111ce611268c4a24bb13720e3f81917a671038f8ab23f14de4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
4.0branch with relevant merged PRs in preparation for tagging the4.0.2release.Included PRs:
#1261
#1267
#1263
#1266
#1264
#1269
#1265
#1268
#1273
#1272
#1274
#1279