[Tests][Bug] Fix staking status in generate_pos() #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
2020_Tests_fix_validtime
branch
from
5bc1ba8 to
7b37d4c
Compare
random-zebra
force-pushed
the
2020_Tests_fix_validtime
branch
4 times, most recently
from
79fabcc to
f6274f2
Compare
|
Needs rebase, #1277 merged. |
"validtime" is not returned from getstakingstatus anymore (nor it was needed).
random-zebra
force-pushed
the
2020_Tests_fix_validtime
branch
from
f6274f2 to
6463949
Compare
Author
|
Rebased on master. |
random-zebra
force-pushed
the
2020_Tests_fix_validtime
branch
from
6463949 to
72d5a31
Compare
|
Reading the last commit, should change the |
Author
|
The same is true for ALL tests. No need to add it. It is already in the config file (check |
Fuzzbawls
approved these changes
Jan 21, 2020
Author
furszy
approved these changes
Jan 21, 2020
furszy
added a commit
that referenced
this pull request
Jan 21, 2020
7a8d755 [Tests] Remove '-staking' from extra-args (random-zebra) 72d5a31 [Tests] Fix/Update mining_pos_coldstaking test (random-zebra) 5ffa6b5 [Trivial] Rename mintablecoins --> stakeablecoins (random-zebra) e781cd0 [Cleanup] zPIV Don't validate Accumulator Checkpoints anymore (random-zebra) 5b192e0 [Tests][Bug] Fix staking status in generate_pos() (random-zebra) Pull request description: This is based on top of #1276 and #1277 which should be reviewed before. `generate_pos` framework function relies on the output of `getstakingstatus` RPC which was recently changed. Since #1245, "validtime" is not returned anymore (nor it was ever really needed here). Only things that we need in `generate_pos` are "walletunlocked" and "mintablecoins" (renamed "stakeablecoins"). "enoughcoins" is going to be removed in #1277 , and "haveconnections" is not required on regtest. This also updates coldstaking test. ACKs for top commit: Fuzzbawls: ACK 7a8d755 furszy: ACK 7a8d755 Tree-SHA512: 0f45d8b3880d8d88258861fc85c04e0c62a834cede8991e1370afcaef05a2fb714a4441e201d0bdfd89251628e92aa51496182b8088917a8f3a9b740a21272f6
furszy
added a commit
that referenced
this pull request
Jan 26, 2020
799e3ad [Tests] Fix block version on RegTest (random-zebra) 00aae54 [Core][Cleanup] PoS: remove extra signature + IncrementExtraNonce (random-zebra) 389094f [Core] Remove StakeV1 in kernel and miner (random-zebra) Pull request description: This removes the old StakeV1 function and does some minor optimizations in the miner code (removing redundant signature and IncrementExtraNonce calls). This is based on top of the following three pull requests and will be rebased after their merge into master. So, they should be reviewed before this one. - [x] #1276 - [x] #1277 - [x] #1278 ACKs for top commit: furszy: Staking working properly, ACK 799e3ad Fuzzbawls: ACK 799e3ad Tree-SHA512: a3cde86fc3a7cdad39d8d322dbcc0da1e34d044c4f320700605a9952e67788c825b53516e5ff452e37cde127aaf902416168dc6384fe62954d336efe7aea23eb
furszy
added a commit
that referenced
this pull request
Jan 27, 2020
9575319 [Tests] Set '-staking' disabled by default on RegTest (random-zebra) Pull request description: Ref: #1278 (comment) Hardcoded default `false` value, instead of having it in the config file for the test nodes. ACKs for top commit: Fuzzbawls: ACK 9575319 furszy: ACK 9575319 Tree-SHA512: 609f4eee57ab9e32a03a88cf014c407348d89f89bbaf6f56187a1bf20e458b7c83d76220f8c047427cd7319cf8ad4b6ff71a4aca06c51b71c6a3ab56efa7cf88
wqking
pushed a commit
to wqking-temp/Vitae
that referenced
this pull request
Jul 27, 2020
9575319460da26dc329b1785420df6c1f5924d3b [Tests] Set '-staking' disabled by default on RegTest (random-zebra) Pull request description: Ref: PIVX-Project/PIVX#1278 (comment) Hardcoded default `false` value, instead of having it in the config file for the test nodes. ACKs for top commit: Fuzzbawls: ACK 9575319460da26dc329b1785420df6c1f5924d3b furszy: ACK 9575319 Tree-SHA512: 609f4eee57ab9e32a03a88cf014c407348d89f89bbaf6f56187a1bf20e458b7c83d76220f8c047427cd7319cf8ad4b6ff71a4aca06c51b71c6a3ab56efa7cf88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of #1276 and #1277 which should be reviewed before.
generate_posframework function relies on the output ofgetstakingstatusRPC which was recently changed.Since #1245, "validtime" is not returned anymore (nor it was ever really needed here).
Only things that we need in
generate_posare "walletunlocked" and "mintablecoins" (renamed "stakeablecoins")."enoughcoins" is going to be removed in #1277 , and "haveconnections" is not required on regtest.
This also updates coldstaking test.