[GUI] CoinControlDialog, every copy to clipboard action implemented. #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y showed label + inform snackbar notifying the user.
random-zebra
previously approved these changes
Jan 14, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
ACK e3dd115
Great change 👍 Much needed.
Mrs-X
previously approved these changes
Jan 14, 2020
Mrs-X
left a comment
Mrs-X
left a comment
There was a problem hiding this comment.
This was on my ToDo list as well, great ❤️
ACK e3dd115 with a little NIT which has no real-life relevance because almost no-one owns that much PIV:
if you copy big amounts (like 17 054 301.41186167) the clipboard-content isn't accepted in the Amount field because of the thousand-separators, so it would make sense to remove those before the value is copied.
… clipboard texts.
Author
|
Updated with latest @Mrs-X comment, now the code removes the extra spacing char/s from the text before copying it to the clipboard. |
random-zebra
added a commit
that referenced
this pull request
Jan 14, 2020
…implemented. c919f0e [GUI] CoinControlDialog, removing extra spacing char from the copy to clipboard texts. (furszy) e3dd115 [GUI] CoinControlDialog, copy to clipboard action implemented on every showed label + inform snackbar notifying the user. (furszy) Pull request description: CoinControlDialog, copy to clipboard action implemented in every showed label + inform snackbar notifying the user.  ACKs for top commit: random-zebra: ACK c919f0e and merging... Tree-SHA512: cac0e599005105f052a2cf34e622447e91a2f01a61876bd6111de85a49c90b99c7699cc7c87e022e092696f60b1cb431688e25ebf33d31125dbd9c664e518b6a
|
Thanks allot for this. Huge help. |
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jan 16, 2020
…y showed label + inform snackbar notifying the user. Github-Pull: PIVX-Project#1269 Rebased-From: e3dd115
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jan 16, 2020
… clipboard texts. Github-Pull: PIVX-Project#1269 Rebased-From: c919f0e
furszy
added a commit
that referenced
this pull request
Jan 16, 2020
4663310 [GUI] Min window size (furszy) 5c76d51 Doc: Update manpages for 4.0.2 (Fuzzbawls) 79bfec9 Build: Bump version to 4.0.2 (Fuzzbawls) 82d0af7 Doc: Update release notes for 4.0.2 (Fuzzbawls) 3432e29 [GUI] Transaction record cold staking fixes. (furszy) e5badbc [RPC] Don't do extra PoW round for pos blocks in 'generate' RPC Github-Pull: #1274 Rebased-From: 6b5ce00 (random-zebra) 7b8169c [Trivial] Update copyright headers for 4.0.2 (Fuzzbawls) 8faf4bf [Core] Update checkpoints for first v7 block (Fuzzbawls) f6e8a14 [GUI] Add latest block number to topbar pushButtonSync Github-Pull: #1268 Rebased-From: 84b4ae4 (random-zebra) 8edfa83 [GUI] Connect P2CSUnlockOwner and P2CSUnlockStaker records to the model Github-Pull: #1265 Rebased-From: 4b24380 (random-zebra) e475827 [GUI] CoinControlDialog, removing extra spacing char from the copy to clipboard texts. (furszy) dbe2b3a [GUI] CoinControlDialog, copy to clipboard action implemented on every showed label + inform snackbar notifying the user. (furszy) 3404bd9 [Wallet] Don't add P2CS automatically to CWalletTx::GetLockedCredit Github-Pull: #1264 Rebased-From: 4789652 (random-zebra) d1f5731 [GUI] Force NavMenu to show dashboard button at startup. (furszy) cdee261 [GUI] Open the app's window in the smallest, currently available, size. (furszy) fc766c8 [GUI] TransactionRecord type P2CSDelegationSentOwner and P2CSDelegationSent distinction. (furszy) 49de2e4 [Qt][Bug] Load the most recent instead of the first transactions (Fuzzbawls) 827ca3e [Bug][GUI] Double counted delegated balance fix. (furszy) Pull request description: Updates the `4.0` branch with relevant merged PRs in preparation for tagging the `4.0.2` release. Included PRs: #1261 #1267 #1263 #1266 #1264 #1269 #1265 #1268 #1273 #1272 #1274 #1279 Top commit has no ACKs. Tree-SHA512: 561d9319d08756c040751c6ce145505610ed2ebc4351a87d9d3bb05ecb98df9f35d492e9e3eb7e111ce611268c4a24bb13720e3f81917a671038f8ab23f14de4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoinControlDialog, copy to clipboard action implemented in every showed label + inform snackbar notifying the user.