[Build] Include full version in release file names #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the build number (CLIENT_VERSION_BUILD) is non-zero, we want to include that in the package version number so the resulting binaries are named with the correct version.
Collaborator
Author
|
example filename output from gitian: |
Warrows
approved these changes
Nov 25, 2019
random-zebra
added a commit
that referenced
this pull request
Nov 25, 2019
298528c build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake) 04f5d5b build: use full version string in setup.exe (MarcoFalke) c787618 Update release-process.md to include RC version bumping (Andrew Chow) 32a69da build: include rc number in version number (Andrew Chow) 8c2b28b build: if VERSION_BUILD is non-zero, include it in the package version (Andrew Chow) Pull request description: This is a backport of the following 3 upstream PRs that result in more precise file names in gitian outputs and in macOS app version info; namely that they are no longer limited to only 3 levels deep (`3.4.0` for example) and will now include the 4th level and/or the RC version if needed (`4.0.0rc1` or `4.0.0.1` for example). bitcoin#14612 bitcoin#14701 bitcoin#15548 Top commit has no ACKs. Tree-SHA512: 1195e9c0af92f4d6c2f7546530d1d5c1046f9139c8f9a03d2d8e092bbbcf5e5c5d046523e8a3712bde3d84bf81252dcc8dbb1ac3f1cdaaa863b1d14c3251fe95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of the following 3 upstream PRs that result in more precise file names in gitian outputs and in macOS app version info; namely that they are no longer limited to only 3 levels deep (
3.4.0for example) and will now include the 4th level and/or the RC version if needed (4.0.0rc1or4.0.0.1for example).bitcoin#14612
bitcoin#14701
bitcoin#15548