[Wallet][RPC] Diagnose unsuitable outputs in lockunspent() #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- qualify as constants the arguments of CWallet's functions: IsLockedCoin, LockCoin and UnlockCoin. - Diagnose unsuitable outputs in lockunspent (backports bitcoin/bitcoin bitcoin#11087)
Fuzzbawls
approved these changes
Nov 8, 2019
furszy
approved these changes
Nov 19, 2019
furszy
added a commit
that referenced
this pull request
Nov 19, 2019
328bad7 [Wallet][RPC] Lock/UnlockCoin const argument + checks in lockunspent (random-zebra) Pull request description: - qualify as constants the arguments of CWallet's functions: `IsLockedCoin`, `LockCoin` and `UnlockCoin`. - Diagnose unsuitable outputs in lockunspent (backports bitcoin#11087) NOTE: the update to `wallet_basic` functional test for this particular changes will be included in a successive PR (which collects updates for the whole test suite). ACKs for top commit: Fuzzbawls: utACK 328bad7 furszy: utACK 328bad7 Tree-SHA512: 43e973d6423dc2d65a9b40ec181c6a6eb96903d4518bfcfa9d39ffeb2cca5866b9630815bb3a83065cd497a00fe39375ad1304c4371cfb2b560b6ac30c5c45ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qualify as constants the arguments of CWallet's functions:
IsLockedCoin,LockCoinandUnlockCoin.Diagnose unsuitable outputs in lockunspent (backports Diagnose unsuitable outputs in lockunspent(). bitcoin/bitcoin#11087)
NOTE: the update to
wallet_basicfunctional test for this particular changes will be included in a successive PR (which collects updates for the whole test suite).