[Qt] Switch to newer connect syntax #1049

Fuzzbawls · 2019-10-20T10:55:02Z

Switch all Qt connections to the newer functor-based syntax.

Marked [WIP] for now until larger PRs can be merged.

Requires the following PR to be merged first in order to adhere to standards:

[Build] Bump minimum required Qt version to 5.5.1 #1351

Mrs-X · 2020-01-19T09:00:05Z

Gone are the times where things just wouldn't work because you got the parameters for the SIGNAL wrong (there's no error message at all for that).
❤️ this PR 👍

Fuzzbawls · 2020-02-25T08:54:13Z

Rebased and ready for review now that #1351 has been merged

random-zebra

ACK edd8e0038e31f922e757c348bad0154d8e590cd3

furszy

I'm half through this PR, leaving some comments from what i have seen up until now.
it's simple but at the same time, intensive to check, lot of files touched. it has some syntax changes and some code changes to be able to do the same that was doing with the previous code syntax.

Will keep moving in the next days.

src/qt/pivx/dashboardwidget.cpp

src/qt/pivx/settings/settingsfaqwidget.cpp

src/qt/pivx/snackbar.cpp

src/qt/pivx/pivxgui.cpp

src/qt/pivx/sendcustomfeedialog.h

src/qt/pivx/receivewidget.cpp

src/qt/pivx/sendcustomfeedialog.cpp

src/qt/pivx/settings/settingsconsolewidget.h

src/qt/pivx/settings/settingsfaqwidget.h

src/qt/pivx/settings/settingsdisplayoptionswidget.cpp

Fuzzbawls · 2020-03-18T22:51:56Z

rebased

furszy

Completed the review, found few more stuff.

src/qt/pivx/sendcustomfeedialog.h

src/qt/pivx/settings/settingsfaqwidget.h

src/qt/pivx/settings/settingsmainoptionswidget.cpp

src/qt/pivx/settings/settingswalletoptionswidget.cpp

src/qt/pivx/tooltipmenu.cpp

Fuzzbawls · 2020-03-23T01:04:23Z

rebased again, lets get this merged

random-zebra

This looks good to me, just a question and a non-blocking nit.

One last minor thing (which we could even address in a successive PR) is the following.
Overloaded signals in QComboBox and QSpinBox (e.g. currentIndexChanged and valueChanged) can use a native helper (QOverload<>::of) to connect with pointer syntax more easily.
For example

static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged)
becomes QOverload<int>::of(&QComboBox::currentIndexChanged)
or similarily static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged)
becomes QOverload<int>::of(&QSpinBox::valueChanged)
or static_cast<void (QSignalMapper::*)()>(&QSignalMapper::map)
becomes QOverload<>::of(&QSignalMapper::map)

etc

src/qt/pivx/expandablebutton.h

src/qt/pivx/settings/settingsnetworkwidget.cpp

furszy

Last things that found from my side.

src/qt/pivx/defaultdialog.cpp

src/qt/pivx/topbar.cpp

furszy

ACK c54fd9d

random-zebra

ACK c54fd9d and merging...

Fuzzbawls · 2020-03-23T22:51:05Z

Commenting here regarding qOverload:

This functionality isn't included in Qt versions prior to 5.7. Per #1292, we need to support versions down to 5.5.

PIVX-Project#1049 missed a few connects that were using the old SIGNAL/SLOT syntax. This updates them to the new syntax.

cb332cc [Qt] Convert leftover connects to Qt5 syntax (Fuzzbawls) Pull request description: #1049 missed a few connects that were using the old SIGNAL/SLOT syntax. This updates them to the new syntax. ACKs for top commit: random-zebra: utACK cb332cc furszy: utACK cb332cc Tree-SHA512: bba240b0d71f6a31677d4e93ba69e462f0438a2ad0199d3b04e0529b401ab383123413e78dede3c63fd643b32f5f5a4b36ecc4e5b2ceacf7e0880635e6c8d4c1

Fuzzbawls added GUI Upstream labels Oct 20, 2019

Fuzzbawls added this to the 4.0.0 milestone Oct 20, 2019

Fuzzbawls self-assigned this Oct 20, 2019

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch 2 times, most recently from 394a695 to 318230b Compare October 21, 2019 04:33

Fuzzbawls modified the milestones: 4.0.0, 4.1.0 Oct 24, 2019

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch 2 times, most recently from eb42566 to 70bd698 Compare January 19, 2020 06:35

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch 2 times, most recently from 95ec730 to edd8e00 Compare February 25, 2020 08:53

Fuzzbawls changed the title ~~[WIP][Qt] Switch to newer connect syntax~~ [Qt] Switch to newer connect syntax Feb 25, 2020

random-zebra previously approved these changes Mar 4, 2020

View reviewed changes

furszy suggested changes Mar 6, 2020

View reviewed changes

furszy reviewed Mar 6, 2020

View reviewed changes

src/qt/pivx/settings/settingsdisplayoptionswidget.cpp Outdated Show resolved Hide resolved

Fuzzbawls dismissed random-zebra’s stale review via cc13b14 March 14, 2020 03:38

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch 2 times, most recently from cc13b14 to 609b990 Compare March 18, 2020 22:50

furszy reviewed Mar 20, 2020

View reviewed changes

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch 2 times, most recently from 6c839a0 to 0199e86 Compare March 23, 2020 01:03

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch from 0199e86 to 4e77c09 Compare March 23, 2020 10:43

random-zebra mentioned this pull request Mar 23, 2020

[GUI] One-click export to file #1424

Merged

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch from 4e77c09 to 24bf733 Compare March 23, 2020 10:53

random-zebra reviewed Mar 23, 2020

View reviewed changes

src/qt/pivx/expandablebutton.h Outdated Show resolved Hide resolved

src/qt/pivx/settings/settingsnetworkwidget.cpp Outdated Show resolved Hide resolved

furszy reviewed Mar 23, 2020

View reviewed changes

src/qt/pivx/defaultdialog.cpp Outdated Show resolved Hide resolved

src/qt/pivx/topbar.cpp Outdated Show resolved Hide resolved

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch from 24bf733 to b1b1330 Compare March 23, 2020 22:40

[Qt] Switch to newer connect syntax

c54fd9d

Fuzzbawls force-pushed the 2019_qt-new-connect-syntax branch from b1b1330 to c54fd9d Compare March 23, 2020 22:46

furszy approved these changes Mar 23, 2020

View reviewed changes

random-zebra approved these changes Mar 23, 2020

View reviewed changes

random-zebra merged commit 521d13b into PIVX-Project:master Mar 23, 2020

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Apr 4, 2020

[Qt] Convert leftover connects to Qt5 syntax

cb332cc

PIVX-Project#1049 missed a few connects that were using the old SIGNAL/SLOT syntax. This updates them to the new syntax.

Fuzzbawls mentioned this pull request Apr 4, 2020

[Qt] Convert leftover connects to Qt5 syntax #1494

Merged

[Qt] Switch to newer connect syntax #1049

[Qt] Switch to newer connect syntax #1049

Uh oh!

Conversation

Fuzzbawls commented Oct 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mrs-X commented Jan 19, 2020

Uh oh!

Fuzzbawls commented Feb 25, 2020

Uh oh!

random-zebra left a comment

Choose a reason for hiding this comment

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fuzzbawls commented Mar 18, 2020

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fuzzbawls commented Mar 23, 2020

Uh oh!

random-zebra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

random-zebra left a comment

Choose a reason for hiding this comment

Uh oh!

Fuzzbawls commented Mar 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fuzzbawls commented Oct 20, 2019 •

edited

Loading