[Qt] Define QT_NO_KEYWORDS #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
force-pushed
the
2019_qt-no-keywords
branch
from
2f54451 to
baff29a
Compare
Collaborator
Author
|
Rebased and updated |
QT_NO_KEYWORDS prevents Qt from defining the `foreach`, `signals`, `slots` and `emit` macros. This avoids overlap between Qt macros and boost, and enforces the standard.
Fuzzbawls
force-pushed
the
2019_qt-no-keywords
branch
from
baff29a to
3c7ec95
Compare
furszy
approved these changes
Jan 30, 2020
furszy
added a commit
that referenced
this pull request
Jan 30, 2020
3c7ec95 [Qt] Define QT_NO_KEYWORDS (Fuzzbawls) Pull request description: QT_NO_KEYWORDS prevents Qt from defining the `foreach`, `signals`, `slots` and `emit` macros. This avoids overlap between Qt macros and boost, and enforces the standard. Marked as [WIP] for the time being so as to not merge and create conflicts with existing open PRs. Can still be reviewed however. Ported mostly from bitcoin#6433 ACKs for top commit: random-zebra: ACK 3c7ec95 furszy: utACK 3c7ec95 Tree-SHA512: 867498a1774ad0d3b1b987e82c5023bead62b2669af8f4343903651e49eab204f3444cbfbc1f9ce54d70546d3d7ea128705d8d46470a8a7bbe01ac82f76cefa9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QT_NO_KEYWORDS prevents Qt from defining the
foreach,signals,slotsandemitmacros.This avoids overlap between Qt macros and boost, and enforces the standard.
Marked as [WIP] for the time being so as to not merge and create conflicts with existing open PRs. Can still be reviewed however.
Ported mostly from bitcoin#6433