[Wallet][Startup][DB][Backport] Remove vchDefaultKey from wallet.h #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OS memory allocation fail handler. * OS signal handler registration method created to remove code duplication. * AppInitBasicSetup() method created, organizing better the setup step of the wallet initialization.
* Stop loading block indexes on wallet startup if shutdown was requested. * Wallet loading, wallet rescan and block index load time logged in a more understandable way.
random-zebra
added
Backport
Startup
…emove vchDefaultKey and have better first run detection". [Wallet][Startup][DB][Backport] Don't create any default address
furszy
force-pushed
the
2019_remove_vchDefaultKey
branch
from
0ca58ef to
6637fd1
Compare
Warrows
approved these changes
Oct 11, 2019
Fuzzbawls
approved these changes
Oct 11, 2019
random-zebra
added a commit
that referenced
this pull request
Oct 11, 2019
…m wallet.h 83d8d00 [Trivial] Init.cpp, instead of use LogPrint, use error. (furszy) 6637fd1 [Wallet][Startup][DB][Backport] bitcoin#10952 BTC back port. Named "Remove vchDefaultKey and have better first run detection". (furszy) Pull request description: Back port from bitcoin#10952. This PR is on top of #1029 because of both PRs modifying `init.cpp`. Check only the last commit. ACKs for top commit: random-zebra: ACK 83d8d00 Warrows: ACK 83d8d00 Fuzzbawls: ACK 83d8d00 Tree-SHA512: 0e05f7f80897a421c541580abbd10af37db083a43c6edf49f61e8d1977c58c6e486b1f17e0eac4fb4e8257200eea3e04b5510321cb4484e110f466f5a5132151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back port from bitcoin#10952.
This PR is on top of #1029 because of both PRs modifying
init.cpp.Check only the last commit.