[Consensus] Remove Old message format in CMasternodeBroadcast #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
approved these changes
Sep 13, 2019
random-zebra
added a commit
that referenced
this pull request
Sep 16, 2019
…dcast a1fcd2a [Consensus] Remove Old message format in CMasternodeBroadcast (random-zebra) Pull request description: The new message format was introduced with protocol 70914 (v3.1.0) and the old message was retained in order to be able to still check against it during the update. After 4 more protocol upgrades we can safely assume that no masternode has MNANNOUNCE message signed with the old format so we can remove it from the code. The function `GetOldStrMessage()` is removed and `GetNewStrMessage()` is renamed to `GetStrMessage()`. ACKs for top commit: furszy: utACK [a1fcd2a](a1fcd2a) Tree-SHA512: 3e1ba50c30ec78d7692a02bf0d557f46cc687a444809703dbf55359470b603fa71d0efb7172dd574f9c231a0041c9fa1a3a1861e8e35f891c4496b90e7f3a21c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new message format was introduced with protocol 70914 (v3.1.0) and the old message was retained in order to be able to still check against it during the update.
After 4 more protocol upgrades we can safely assume that no masternode has MNANNOUNCE message signed with the old format so we can remove it from the code.
The function
GetOldStrMessage()is removed andGetNewStrMessage()is renamed toGetStrMessage().