[BUG][RPC] fix signature check (against old format) in mnbudgetrawvote

random-zebra · Fuzzbawls · commit ffac2a708b8a · 2020-01-11T15:42:47.000-08:00
Github-Pull: #1206 Rebased-From: ae063d0
diff --git a/src/rpc/budget.cpp b/src/rpc/budget.cpp
@@ -733,7 +733,9 @@ UniValue mnbudgetrawvote(const UniValue& params, bool fHelp)
     vote.SetVchSig(vchSig);
 
     if (!vote.CheckSignature(true)) {
-        return "Failure to verify signature.";
+        // try old message version
+        vote.nMessVersion = MessageVersion::MESS_VER_STRMESS;
+        if (!vote.CheckSignature(true)) return "Failure to verify signature.";
     }
 
     std::string strError = "";

Original file line number	Diff line number	Diff line change
`@@ -733,7 +733,9 @@ UniValue mnbudgetrawvote(const UniValue& params, bool fHelp)`
`733`	`733`	`vote.SetVchSig(vchSig);`
`734`	`734`
`735`	`735`	`if (!vote.CheckSignature(true)) {`
`736`		`- return "Failure to verify signature.";`
	`736`	`+ // try old message version`
	`737`	`+ vote.nMessVersion = MessageVersion::MESS_VER_STRMESS;`
	`738`	`+ if (!vote.CheckSignature(true)) return "Failure to verify signature.";`
`737`	`739`	`}`
`738`	`740`
`739`	`741`	`std::string strError = "";`