Introduce startBlockHeight to make things more explicit

codablock · panleone · commit fdba615ec308 · 2024-04-07T13:02:22.000+02:00
diff --git a/src/llmq/quorums_signing.cpp b/src/llmq/quorums_signing.cpp
@@ -558,10 +558,11 @@ CQuorumCPtr CSigningManager::SelectQuorumForSigning(Consensus::LLMQType llmqType
     CBlockIndex* pindexStart;
     {
         LOCK(cs_main);
-        if (signHeight - SIGN_HEIGHT_OFFSET > chainActive.Height()) {
+        int startBlockHeight = signHeight - SIGN_HEIGHT_OFFSET;
+        if (startBlockHeight > chainActive.Height()) {
             return nullptr;
         }
-        pindexStart = chainActive[signHeight - SIGN_HEIGHT_OFFSET];
+        pindexStart = chainActive[startBlockHeight];
     }
 
     auto quorums = quorumManager->ScanQuorums(llmqType, pindexStart, poolSize);

Original file line number	Diff line number	Diff line change
`@@ -558,10 +558,11 @@ CQuorumCPtr CSigningManager::SelectQuorumForSigning(Consensus::LLMQType llmqType`
`558`	`558`	`CBlockIndex* pindexStart;`
`559`	`559`	`{`
`560`	`560`	`LOCK(cs_main);`
`561`		`- if (signHeight - SIGN_HEIGHT_OFFSET > chainActive.Height()) {`
	`561`	`+ int startBlockHeight = signHeight - SIGN_HEIGHT_OFFSET;`
	`562`	`+ if (startBlockHeight > chainActive.Height()) {`
`562`	`563`	`return nullptr;`
`563`	`564`	`}`
`564`		`- pindexStart = chainActive[signHeight - SIGN_HEIGHT_OFFSET];`
	`565`	`+ pindexStart = chainActive[startBlockHeight];`
`565`	`566`	`}`
`566`	`567`
`567`	`568`	`auto quorums = quorumManager->ScanQuorums(llmqType, pindexStart, poolSize);`