Skip to content

Commit f9141f8

Browse files
jnewberyrandom-zebra
jnewbery
authored and
random-zebra
committed
[QA] Add wallet_multiwallet.py functional test
1 parent 2e02006 commit f9141f8

File tree

1 file changed

+151
-0
lines changed

1 file changed

+151
-0
lines changed

‎test/functional/wallet_multiwallet.py‎

Lines changed: 151 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,151 @@
1+
#!/usr/bin/env python3
2+
# Copyright (c) 2017 The Bitcoin Core developers
3+
# Copyright (c) 2021 The PIVX developers
4+
# Distributed under the MIT software license, see the accompanying
5+
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
6+
"""Test multiwallet.
7+
8+
Verify that a pivxd node can load multiple wallet files
9+
"""
10+
import os
11+
import shutil
12+
13+
from test_framework.test_framework import PivxTestFramework
14+
from test_framework.util import assert_equal, assert_raises_rpc_error
15+
16+
class MultiWalletTest(PivxTestFramework):
17+
def set_test_params(self):
18+
self.setup_clean_chain = True
19+
self.num_nodes = 2
20+
self.extra_args = [['-wallet=w1', '-wallet=w2', '-wallet=w3', '-wallet=w'], []]
21+
self.supports_cli = True
22+
23+
def run_test(self):
24+
node = self.nodes[0]
25+
26+
data_dir = lambda *p: os.path.join(node.datadir, 'regtest', *p)
27+
wallet_dir = lambda *p: data_dir('wallets', *p)
28+
wallet = lambda name: node.get_wallet_rpc(name)
29+
30+
# !TODO: implement listwallets (bitcoin#11310)
31+
#assert_equal(set(node.listwallets()), {"w1", "w2", "w3", "w"})
32+
33+
self.stop_nodes()
34+
35+
# !TODO: backport bitcoin#12220
36+
#self.assert_start_raises_init_error(0, ['-walletdir=wallets'], 'Error: Specified -walletdir "wallets" does not exist')
37+
#self.assert_start_raises_init_error(0, ['-walletdir=wallets'], 'Error: Specified -walletdir "wallets" is a relative path', cwd=data_dir())
38+
#self.assert_start_raises_init_error(0, ['-walletdir=debug.log'], 'Error: Specified -walletdir "debug.log" is not a directory', cwd=data_dir())
39+
40+
# should not initialize if there are duplicate wallets
41+
# !TODO: backport bitcoin#10885
42+
#self.assert_start_raises_init_error(0, ['-wallet=w1', '-wallet=w1'], 'Error loading wallet w1. Duplicate -wallet filename specified.')
43+
44+
# should not initialize if wallet file is a directory
45+
# !TODO: backport bitcoin#11476 + bitcoin#11970
46+
# os.mkdir(wallet_dir('w11'))
47+
# self.assert_start_raises_init_error(0, ['-wallet=w11'], 'Error loading wallet w11. -wallet filename must be a regular file.')
48+
49+
# should not initialize if one wallet is a copy of another
50+
# shutil.copyfile(wallet_dir('w2'), wallet_dir('w22'))
51+
# self.assert_start_raises_init_error(0, ['-wallet=w2', '-wallet=w22'], 'duplicates fileid')
52+
53+
# should not initialize if wallet file is a symlink
54+
# !TODO: backport bitcoin#10885
55+
# os.symlink(wallet_dir('w1'), wallet_dir('w12'))
56+
# self.assert_start_raises_init_error(0, ['-wallet=w12'], 'Error loading wallet w12. -wallet filename must be a regular file.')
57+
58+
self.log.info("Do not allow -zapwallettxes with multiwallet")
59+
self.assert_start_raises_init_error(0, ['-zapwallettxes', '-wallet=w1', '-wallet=w2'], "Error: -zapwallettxes is only allowed with a single wallet file")
60+
self.assert_start_raises_init_error(0, ['-zapwallettxes=1', '-wallet=w1', '-wallet=w2'], "Error: -zapwallettxes is only allowed with a single wallet file")
61+
self.assert_start_raises_init_error(0, ['-zapwallettxes=2', '-wallet=w1', '-wallet=w2'], "Error: -zapwallettxes is only allowed with a single wallet file")
62+
63+
self.log.info("Do not allow -salvagewallet with multiwallet")
64+
self.assert_start_raises_init_error(0, ['-salvagewallet', '-wallet=w1', '-wallet=w2'], "Error: -salvagewallet is only allowed with a single wallet file")
65+
self.assert_start_raises_init_error(0, ['-salvagewallet=1', '-wallet=w1', '-wallet=w2'], "Error: -salvagewallet is only allowed with a single wallet file")
66+
67+
self.log.info("Do not allow -upgradewallet with multiwallet")
68+
self.assert_start_raises_init_error(0, ['-upgradewallet', '-wallet=w1', '-wallet=w2'], "Error: -upgradewallet is only allowed with a single wallet file")
69+
self.assert_start_raises_init_error(0, ['-upgradewallet=1', '-wallet=w1', '-wallet=w2'], "Error: -upgradewallet is only allowed with a single wallet file")
70+
71+
# !TODO: backport bitcoin#12220
72+
'''
73+
# if wallets/ doesn't exist, datadir should be the default wallet dir
74+
wallet_dir2 = data_dir('walletdir')
75+
os.rename(wallet_dir(), wallet_dir2)
76+
self.start_node(0, ['-wallet=w4', '-wallet=w5'])
77+
assert_equal(set(node.listwallets()), {"w4", "w5"})
78+
w5 = wallet("w5")
79+
w5.generate(1)
80+
81+
# now if wallets/ exists again, but the rootdir is specified as the walletdir, w4 and w5 should still be loaded
82+
os.rename(wallet_dir2, wallet_dir())
83+
self.restart_node(0, ['-wallet=w4', '-wallet=w5', '-walletdir=' + data_dir()])
84+
assert_equal(set(node.listwallets()), {"w4", "w5"})
85+
w5 = wallet("w5")
86+
w5_info = w5.getwalletinfo()
87+
assert_equal(w5_info['immature_balance'], 50)
88+
89+
competing_wallet_dir = os.path.join(self.options.tmpdir, 'competing_walletdir')
90+
os.mkdir(competing_wallet_dir)
91+
self.restart_node(0, ['-walletdir='+competing_wallet_dir])
92+
self.assert_start_raises_init_error(1, ['-walletdir='+competing_wallet_dir], 'Error initializing wallet database environment')
93+
'''
94+
self.restart_node(0, self.extra_args[0])
95+
96+
w1 = wallet("w1")
97+
w2 = wallet("w2")
98+
w3 = wallet("w3")
99+
w4 = wallet("w")
100+
wallet_bad = wallet("bad")
101+
102+
w1.generate(1)
103+
104+
# accessing invalid wallet fails
105+
assert_raises_rpc_error(-8, "Requested wallet does not exist or is not loaded", wallet_bad.getwalletinfo)
106+
107+
# accessing wallet RPC without using wallet endpoint fails
108+
# !TODO: backport bitcoin#11970
109+
#assert_raises_rpc_error(-19, "Wallet file not specified", node.getwalletinfo)
110+
111+
# !TODO: implement listwallets (bitcoin#11310) and backport bitcoin#11473
112+
# to un-comment wallet-name checks
113+
114+
# check w1 wallet balance
115+
w1_info = w1.getwalletinfo()
116+
assert_equal(w1_info['immature_balance'], 250)
117+
#w1_name = w1_info['walletname']
118+
#assert_equal(w1_name, "w1")
119+
120+
# check w2 wallet balance
121+
w2_info = w2.getwalletinfo()
122+
assert_equal(w2_info['immature_balance'], 0)
123+
#w2_name = w2_info['walletname']
124+
#assert_equal(w2_name, "w2")
125+
126+
#w3_name = w3.getwalletinfo()['walletname']
127+
#assert_equal(w3_name, "w3")
128+
129+
#w4_name = w4.getwalletinfo()['walletname']
130+
#assert_equal(w4_name, "w")
131+
132+
w1.generate(101)
133+
assert_equal(w1.getbalance(), 500)
134+
assert_equal(w2.getbalance(), 0)
135+
assert_equal(w3.getbalance(), 0)
136+
assert_equal(w4.getbalance(), 0)
137+
138+
w1.sendtoaddress(w2.getnewaddress(), 1)
139+
w1.sendtoaddress(w3.getnewaddress(), 2)
140+
w1.sendtoaddress(w4.getnewaddress(), 3)
141+
w1.generate(1)
142+
assert_equal(w2.getbalance(), 1)
143+
assert_equal(w3.getbalance(), 2)
144+
assert_equal(w4.getbalance(), 3)
145+
146+
batch = w1.batch([w1.getblockchaininfo.get_request(), w1.getwalletinfo.get_request()])
147+
assert_equal(batch[0]["result"]["chain"], "regtest")
148+
#assert_equal(batch[1]["result"]["walletname"], "w1")
149+
150+
if __name__ == '__main__':
151+
MultiWalletTest().main()

0 commit comments

Comments
 (0)