[Mempool][Sapling] Introduce CTxMemPool::checkNullifiers

random-zebra · random-zebra · commit ef1785576838 · 2020-11-11T14:38:10.000+01:00
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
@@ -727,10 +727,24 @@ void CTxMemPool::check(const CCoinsViewCache* pcoins) const
         assert(it->first == it->second.ptx->vin[it->second.n].prevout);
     }
 
+    // Consistency check for sapling nullifiers
+    checkNullifiers();
+
     assert(totalTxSize == checkTotal);
     assert(innerUsage == cachedInnerUsage);
 }
 
+void CTxMemPool::checkNullifiers() const
+{
+    for (const auto& it : mapSaplingNullifiers) {
+        const uint256& hash = it.second->GetHash();
+        const auto& findTx = mapTx.find(hash);
+        assert(findTx != mapTx.end());
+        const CTransaction& tx = findTx->GetTx();
+        assert(&tx == it.second);
+    }
+}
+
 void CTxMemPool::queryHashes(std::vector<uint256>& vtxid)
 {
     vtxid.clear();
diff --git a/src/txmempool.h b/src/txmempool.h
@@ -469,6 +469,7 @@ class CTxMemPool
      */
     void check(const CCoinsViewCache *pcoins) const;
     void setSanityCheck(double dFrequency = 1.0) { nCheckFrequency = dFrequency * 4294967295.0; }
+    void checkNullifiers() const;
 
     // addUnchecked must updated state for all ancestors of a given transaction,
     // to track size/count of descendant transactions.  First version of
