GetMasternodeInputAge: Missing cs_main lock

furszy · Fuzzbawls · commit eeb112f1c00e · 2020-08-12T17:20:41.000-07:00
Github-Pull: #1791 Rebased-From: 224c8fd
diff --git a/src/masternode.h b/src/masternode.h
@@ -251,14 +251,20 @@ class CMasternode : public CSignedMessage
 
     int GetMasternodeInputAge()
     {
-        if (chainActive.Tip() == NULL) return 0;
+        int tipHeight;
+        {
+            LOCK(cs_main);
+            CBlockIndex *pindex = chainActive.Tip();
+            if (!pindex) return 0;
+            tipHeight = pindex->nHeight;
+        }
 
         if (cacheInputAge == 0) {
             cacheInputAge = GetInputAge(vin);
-            cacheInputAgeBlock = chainActive.Tip()->nHeight;
+            cacheInputAgeBlock = tipHeight;
         }
 
-        return cacheInputAge + (chainActive.Tip()->nHeight - cacheInputAgeBlock);
+        return cacheInputAge + (tipHeight - cacheInputAgeBlock);
     }
 
     std::string Status()
