net_processing: Remove duplicate, and wrong, peer misbehaving due an invalid arriving block.

furszy · furszy · commit e6d2bd642191 · 2021-07-21T17:28:24.000-03:00
1) The actual peer misbehaving check is being performed inside PeerLogicValidation::BlockChecked.
2) The CValidationState inputted to ProcessNewBlock does not return the error nor invalidity reason if the block is marked as invalid during the activate best chain process (thus why BlockChecked exists).
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
@@ -1703,14 +1703,6 @@ bool static ProcessMessage(CNode* pfrom, std::string strCommand, CDataStream& vR
                 if (!fAccepted) {
                     CheckBlockSpam(state, pfrom, hashBlock);
                 }
-                int nDoS;
-                if(state.IsInvalid(nDoS)) {
-                    assert (state.GetRejectCode() < REJECT_INTERNAL); // Blocks are never rejected with internal reject codes
-                    if(nDoS > 0) {
-                        TRY_LOCK(cs_main, lockMain);
-                        if(lockMain) Misbehaving(pfrom->GetId(), nDoS);
-                    }
-                }
                 //disconnect this node if its old protocol version
                 pfrom->DisconnectOldProtocol(pfrom->nVersion, ActiveProtocol(), strCommand);
             } else {
