Tests: Update sapling_malleable-sigs test, now failing

random-zebra · random-zebra · commit e5b8dbafaa4b · 2020-12-15T23:12:21.000+01:00
diff --git a/test/functional/sapling_malleable_sigs.py b/test/functional/sapling_malleable_sigs.py
@@ -11,7 +11,7 @@
 )
 from test_framework.util import (
     assert_equal,
-    assert_greater_than,
+    assert_raises_rpc_error,
     bytes_to_hex_str,
     hex_str_to_bytes,
 )
@@ -31,9 +31,6 @@ def run_test(self):
         node.generate(2)
         assert_equal(node.getblockcount(), 202)
 
-        t_balance = node.getbalance()
-        z_balance = node.getshieldedbalance()
-
         z_addr = node.getnewshieldedaddress()
         shield_to = [{"address": z_addr, "amount": Decimal('10')}]
 
@@ -49,24 +46,9 @@ def run_test(self):
         new_tx.sapData = b""
         new_rawtx = bytes_to_hex_str(new_tx.serialize())
         self.log.info("Sending malleated tx...")
-        txid = node.sendrawtransaction(new_rawtx, True)
-        assert(txid is not None)
-        self.log.info("Tx accepted in mempool")
-
-        # No notes minted
-        assert_equal(node.getshieldedbalance(), z_balance)
-        # But 10 PIV have been effectively burned
-        fee = - Decimal(node.gettransaction(txid)['fee'])
-        assert_greater_than(fee, Decimal('10'))
-        assert_equal(node.getbalance(), t_balance - fee)
-
-        hashes = node.generate(1)
-        assert_equal(len(hashes), 1)
-        chain_tx = node.gettransaction(txid)
-        assert_equal(chain_tx['confirmations'], 1)
-        self.log.info("Malleated Tx accepted on chain")
-
-
+        assert_raises_rpc_error(-26, "mandatory-script-verify-flag-failed",
+                                node.sendrawtransaction, new_rawtx, True)
+        self.log.info("Good. Tx NOT accepted in mempool")
 
 
 
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
@@ -154,6 +154,7 @@
     'sapling_mempool.py',                       # ~ 98 sec
     'sapling_wallet_persistence.py',            # ~ 90 sec
     'sapling_supply.py',                        # ~ 58 sec
+    'sapling_malleable_sigs.py',                # ~ 44 sec
 ]
 
 EXTENDED_SCRIPTS = [

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,7 @@`
`154`	`154`	`'sapling_mempool.py', # ~ 98 sec`
`155`	`155`	`'sapling_wallet_persistence.py', # ~ 90 sec`
`156`	`156`	`'sapling_supply.py', # ~ 58 sec`
	`157`	`+ 'sapling_malleable_sigs.py', # ~ 44 sec`
`157`	`158`	`]`
`158`	`159`
`159`	`160`	`EXTENDED_SCRIPTS = [`