[BUG] Memory leak after new CNode / ConnectNode

random-zebra · random-zebra · commit e4f9ab3f79c6 · 2021-02-13T15:46:43.000+01:00
diff --git a/src/activemasternode.cpp b/src/activemasternode.cpp
@@ -115,6 +115,9 @@ void CActiveMasternode::ManageStatus()
                         "Masternode address:port connection availability test failed, could not open a connection to the public masternode address (" +
                         service.ToString() + ")";
                 LogPrintf("%s - not capable: %s\n", __func__, notCapableReason);
+            } else {
+                // don't leak allocated object in memory
+                delete node;
             }
             return;
         }
diff --git a/src/test/net_tests.cpp b/src/test/net_tests.cpp
@@ -174,6 +174,9 @@ BOOST_AUTO_TEST_CASE(cnode_simple_test)
     CNode* pnode2 = new CNode(id++, NODE_NETWORK, height, hSocket, addr, 1, 1, pszDest, fInboundIn);
     BOOST_CHECK(pnode2->fInbound == true);
     BOOST_CHECK(pnode2->fFeeler == false);
+
+    delete pnode1;
+    delete pnode2;
 }
 
 BOOST_AUTO_TEST_SUITE_END()

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,9 @@ void CActiveMasternode::ManageStatus()`
`115`	`115`	`"Masternode address:port connection availability test failed, could not open a connection to the public masternode address (" +`
`116`	`116`	`service.ToString() + ")";`
`117`	`117`	`LogPrintf("%s - not capable: %s\n", __func__, notCapableReason);`
	`118`	`+ } else {`
	`119`	`+ // don't leak allocated object in memory`
	`120`	`+ delete node;`
`118`	`121`	`}`
`119`	`122`	`return;`
`120`	`123`	`}`
Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,9 @@ BOOST_AUTO_TEST_CASE(cnode_simple_test)`
`174`	`174`	`CNode* pnode2 = new CNode(id++, NODE_NETWORK, height, hSocket, addr, 1, 1, pszDest, fInboundIn);`
`175`	`175`	`BOOST_CHECK(pnode2->fInbound == true);`
`176`	`176`	`BOOST_CHECK(pnode2->fFeeler == false);`
	`177`	`+`
	`178`	`+ delete pnode1;`
	`179`	`+ delete pnode2;`
`177`	`180`	`}`
`178`	`181`
`179`	`182`	`BOOST_AUTO_TEST_SUITE_END()`