[Consensus] Don't Allow ProUpReg txes while in transition to DMN

random-zebra · random-zebra · commit e2081a7056d7 · 2021-07-06T16:01:12.000+02:00
As changing the payout address, could be used maliciously to game the
old payment system.
diff --git a/src/evo/providertx.cpp b/src/evo/providertx.cpp
@@ -384,6 +384,12 @@ bool CheckProUpRegTx(const CTransaction& tx, const CBlockIndex* pindexPrev, CVal
     }
 
     if (pindexPrev) {
+        // ProUpReg txes are disabled when the legacy system is still active
+        // !TODO: remove after complete transition to DMN
+        if (!deterministicMNManager->LegacyMNObsolete(pindexPrev->nHeight + 1)) {
+            return state.DoS(10, false, REJECT_INVALID, "spork-21-inactive");
+        }
+
         auto mnList = deterministicMNManager->GetListForBlock(pindexPrev);
         auto dmn = mnList.GetMN(pl.proTxHash);
         if (!dmn) {
diff --git a/src/rpc/rpcevo.cpp b/src/rpc/rpcevo.cpp
@@ -862,6 +862,10 @@ UniValue protx_update_registrar(const JSONRPCRequest& request)
     }
     CheckEvoUpgradeEnforcement();
 
+    if (!deterministicMNManager->LegacyMNObsolete()) {
+        throw JSONRPCError(RPC_MISC_ERROR, "Legacy masternode system still active. ProUpReg transactions are not accepted yet.");
+    }
+
     EnsureWalletIsUnlocked(pwallet);
     // Make sure the results are valid at least up to the most recent block
     // the user could have gotten from another RPC command prior to now
