Future: Introduce future function to validate proposal strings

Fuzzbawls · Fuzzbawls · commit dc11219f25e0 · 2022-05-16T07:33:46.000-07:00
Future implementation of string validation on the network level for
proposal name/URL
diff --git a/src/budget/budgetproposal.cpp b/src/budget/budgetproposal.cpp
@@ -6,6 +6,7 @@
 #include "budget/budgetproposal.h"
 #include "chainparams.h"
 #include "script/standard.h"
+#include "utilstrencodings.h"
 
 CBudgetProposal::CBudgetProposal():
         nAllotted(0),
@@ -145,6 +146,20 @@ bool CBudgetProposal::CheckAddress()
     return true;
 }
 
+/* TODO: Add this to IsWellFormed() for the next hard-fork
+ * This will networkly reject malformed proposal names and URLs
+ */
+bool CBudgetProposal::CheckStrings()
+{
+    if (strProposalName != SanitizeString(strProposalName)) {
+        strInvalid = "Proposal name contains illegal characters.";
+        return false;
+    }
+    if (strURL != SanitizeString(strURL)) {
+        strInvalid = "Proposal URL contains illegal characters.";
+    }
+}
+
 bool CBudgetProposal::IsWellFormed(const CAmount& nTotalBudget)
 {
     return CheckStartEnd() && CheckAmount(nTotalBudget) && CheckAddress();
diff --git a/src/budget/budgetproposal.h b/src/budget/budgetproposal.h
@@ -42,6 +42,7 @@ class CBudgetProposal
     bool CheckStartEnd();
     bool CheckAmount(const CAmount& nTotalBudget);
     bool CheckAddress();
+    bool CheckStrings();
 
 protected:
     std::map<COutPoint, CBudgetVote> mapVotes;
