[Tests] Add functional test for import staking address/key

random-zebra · random-zebra · commit d1ebf2eb4c7c · 2020-01-09T05:03:29.000+01:00
diff --git a/src/wallet/rpcdump.cpp b/src/wallet/rpcdump.cpp
@@ -139,7 +139,7 @@ UniValue importprivkey(const UniValue& params, bool fHelp)
 
         if (fRescan) {
             CBlockIndex *pindex = chainActive.Genesis();
-            if (fStakingAddress) {
+            if (fStakingAddress && Params().NetworkID() != CBaseChainParams::REGTEST) {
                 // cold staking was activated after nBlockTimeProtocolV2. No need to scan the whole chain
                 pindex = chainActive[Params().BlockStartTimeProtocolV2()];
             }
diff --git a/test/functional/wallet_import_stakingaddress.py b/test/functional/wallet_import_stakingaddress.py
@@ -0,0 +1,89 @@
+#!/usr/bin/env python3
+# Copyright (c) 2020 The PIVX developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+'''
+Tests importprivkey and importaddress with staking keys/addresses.
+Node0 generates staking addresses and sends delegations to them.
+Node1 imports and rescans. The test checks that cold utxos and staking balance is updated.
+'''
+
+from time import sleep
+
+from test_framework.test_framework import PivxTestFramework
+from test_framework.util import (
+    assert_equal,
+    DecimalAmt,
+    sync_blocks,
+)
+
+class ImportStakingTest(PivxTestFramework):
+
+    def set_test_params(self):
+        self.num_nodes = 2
+        self.extra_args = [['-staking=0']] * self.num_nodes
+        self.extra_args[0].append('-sporkkey=932HEevBSujW2ud7RfB1YF91AFygbBRQj3de3LyaCRqNzKKgWXi')
+
+    def log_title(self):
+        title = "*** Starting %s ***" % self.__class__.__name__
+        underline = "-" * len(title)
+        description = "Tests importprivkey and importaddress with staking keys/addresses."
+        self.log.info("\n\n%s\n%s\n%s\n", title, underline, description)
+
+    def run_test(self):
+        NUM_OF_DELEGATIONS = 4  # Create 2*NUM_OF_DELEGATIONS staking addresses
+        self.log_title()
+        self.log.info("Activating cold staking spork")
+        assert_equal("success", self.activate_spork(0, "SPORK_17_COLDSTAKING_ENFORCEMENT"))
+
+        # Create cold staking addresses and delegations
+        self.log.info("Creating new staking addresses and sending delegations")
+        staking_addresses = [self.nodes[0].getnewstakingaddress("label %d" % i)
+                             for i in range(2 * NUM_OF_DELEGATIONS)]
+        delegations = []
+        for i, sa in enumerate(staking_addresses):
+            # delegate 10 PIV
+            delegations.append(self.nodes[0].delegatestake(sa, 10)['txid'])
+            # mine a block and check staking balance
+            self.nodes[0].generate(1)
+            assert_equal(self.nodes[0].getcoldstakingbalance(), DecimalAmt(10 * (i+1)))
+            sync_blocks(self.nodes)
+
+        # Export keys
+        self.log.info("Exporting keys and importing in node 1")
+        priv_keys = [self.nodes[0].dumpprivkey(x) for x in staking_addresses]
+
+        # Import keys of addresses 0-(NUM_OF_DELEGATIONS-1) (and rescan)
+        assert_equal(self.nodes[1].getcoldstakingbalance(), DecimalAmt(0))
+        for i, pk in enumerate(priv_keys[:NUM_OF_DELEGATIONS]):
+            self.nodes[1].importprivkey(pk, "label %d" % i, True, True)
+            val = self.nodes[1].validateaddress(staking_addresses[i])
+            assert_equal(val['ismine'], True)
+            assert_equal(val['isstaking'], True)
+            assert_equal(val['iswatchonly'], False)
+            assert_equal(self.nodes[1].getcoldstakingbalance(), DecimalAmt(10 * (i + 1)))
+        self.log.info("Balance of node 1 checks out")
+        coldutxos = [x['txid'] for x in self.nodes[1].listcoldutxos()]
+        assert_equal(len(coldutxos), NUM_OF_DELEGATIONS)
+        assert_equal(len([x for x in coldutxos if x in delegations]), NUM_OF_DELEGATIONS)
+        self.log.info("Delegation list of node 1 checks out")
+
+        # Import remaining addresses as watch-only (and rescan again)
+        self.log.info("Importing addresses (watch-only)")
+        for i, sa in enumerate(staking_addresses[NUM_OF_DELEGATIONS:]):
+            self.nodes[1].importaddress(sa, "label %d" % i, True)
+            # !TODO: add watch-only support in the core (balance and txes)
+            # Currently the only way to check the addressbook without the key here
+            # is to verify the account with validateaddress
+            val = self.nodes[1].validateaddress(sa)
+            assert_equal(val['ismine'], False)
+            assert_equal(val['isstaking'], True)
+            assert_equal(val['iswatchonly'], True)
+            assert_equal(self.nodes[1].getcoldstakingbalance(), DecimalAmt(10 * NUM_OF_DELEGATIONS))
+        self.log.info("Balance of node 1 checks out")
+
+
+
+if __name__ == '__main__':
+    ImportStakingTest().main()

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ UniValue importprivkey(const UniValue& params, bool fHelp)`
`139`	`139`
`140`	`140`	`if (fRescan) {`
`141`	`141`	`CBlockIndex *pindex = chainActive.Genesis();`
`142`		`- if (fStakingAddress) {`
	`142`	`+ if (fStakingAddress && Params().NetworkID() != CBaseChainParams::REGTEST) {`
`143`	`143`	`// cold staking was activated after nBlockTimeProtocolV2. No need to scan the whole chain`
`144`	`144`	`pindex = chainActive[Params().BlockStartTimeProtocolV2()];`
`145`	`145`	`}`