[Cleanup] Drop unneeded casts

random-zebra · random-zebra · commit cdd44d48764a · 2021-04-11T10:22:03.000+02:00
diff --git a/src/budget/budgetproposal.cpp b/src/budget/budgetproposal.cpp
@@ -58,7 +58,7 @@ bool CBudgetProposal::ParseBroadcast(CDataStream& broadcast)
         broadcast >> nBlockStart;
         broadcast >> nBlockEnd;
         broadcast >> nAmount;
-        broadcast >> *(CScriptBase*)(&address);
+        broadcast >> address;
         broadcast >> nFeeTXHash;
     } catch (std::exception& e) {
         return error("Unable to deserialize proposal broadcast: %s", e.what());
@@ -338,7 +338,7 @@ CDataStream CBudgetProposal::GetBroadcast() const
     broadcast << nBlockStart;
     broadcast << nBlockEnd;
     broadcast << nAmount;
-    broadcast << *(CScriptBase*)(&address);
+    broadcast << address;
     broadcast << nFeeTXHash;
     return broadcast;
 }
diff --git a/src/budget/budgetproposal.h b/src/budget/budgetproposal.h
@@ -115,7 +115,7 @@ class CBudgetProposal
         READWRITE(nBlockStart);
         READWRITE(nBlockEnd);
         READWRITE(nAmount);
-        READWRITE(*(CScriptBase*)(&address));
+        READWRITE(address);
         READWRITE(nFeeTXHash);
         READWRITE(nTime);
         READWRITE(mapVotes);
diff --git a/src/budget/finalizedbudget.h b/src/budget/finalizedbudget.h
@@ -161,7 +161,7 @@ class CTxBudgetPayment
     template <typename Stream, typename Operation>
     inline void SerializationOp(Stream& s, Operation ser_action)
     {
-        READWRITE(*(CScriptBase*)(&payee));
+        READWRITE(payee);
         READWRITE(nAmount);
         READWRITE(nProposalHash);
     }
diff --git a/src/masternode-payments.h b/src/masternode-payments.h
@@ -78,7 +78,7 @@ class CMasternodePayee
     template <typename Stream, typename Operation>
     inline void SerializationOp(Stream& s, Operation ser_action)
     {
-        READWRITE(*(CScriptBase*)(&scriptPubKey));
+        READWRITE(scriptPubKey);
         READWRITE(nVotes);
     }
 };
@@ -199,7 +199,7 @@ class CMasternodePaymentWinner : public CSignedMessage
     {
         READWRITE(vinMasternode);
         READWRITE(nBlockHeight);
-        READWRITE(*(CScriptBase*)(&payee));
+        READWRITE(payee);
         READWRITE(vchSig);
         try
         {

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ class CTxBudgetPayment`
`161`	`161`	`template <typename Stream, typename Operation>`
`162`	`162`	`inline void SerializationOp(Stream& s, Operation ser_action)`
`163`	`163`	`{`
`164`		`- READWRITE((CScriptBase)(&payee));`
	`164`	`+ READWRITE(payee);`
`165`	`165`	`READWRITE(nAmount);`
`166`	`166`	`READWRITE(nProposalHash);`
`167`	`167`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ class CMasternodePayee`
`78`	`78`	`template <typename Stream, typename Operation>`
`79`	`79`	`inline void SerializationOp(Stream& s, Operation ser_action)`
`80`	`80`	`{`
`81`		`- READWRITE((CScriptBase)(&scriptPubKey));`
	`81`	`+ READWRITE(scriptPubKey);`
`82`	`82`	`READWRITE(nVotes);`
`83`	`83`	`}`
`84`	`84`	`};`
`@@ -199,7 +199,7 @@ class CMasternodePaymentWinner : public CSignedMessage`
`199`	`199`	`{`
`200`	`200`	`READWRITE(vinMasternode);`
`201`	`201`	`READWRITE(nBlockHeight);`
`202`		`- READWRITE((CScriptBase)(&payee));`
	`202`	`+ READWRITE(payee);`
`203`	`203`	`READWRITE(vchSig);`
`204`	`204`	`try`
`205`	`205`	`{`