GUI: Update worker type if task already exist.

furszy · furszy · commit ca3edc5b01e1 · 2021-03-11T17:37:07.000-03:00
So it doesn't invalidly re-use the cached one.
diff --git a/src/qt/pivx/loadingdialog.h b/src/qt/pivx/loadingdialog.h
@@ -25,6 +25,7 @@ class Worker : public QObject {
         runnable = nullptr;
     }
     virtual void clean() {};
+    void setType(int _type) { type = _type; }
 public Q_SLOTS:
     void process();
 Q_SIGNALS:
diff --git a/src/qt/pivx/pwidget.cpp b/src/qt/pivx/pwidget.cpp
@@ -108,6 +108,8 @@ bool PWidget::execute(int type, std::unique_ptr<WalletModel::UnlockContext> pctx
             WalletWorker* _worker = static_cast<WalletWorker*>(task->worker.data());
             _worker->setContext(std::move(pctx));
         }
+        // Update type
+        task->worker->setType(type);
     }
     QThreadPool::globalInstance()->start(task.data());
     return true;

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ class Worker : public QObject {`
`25`	`25`	`runnable = nullptr;`
`26`	`26`	`}`
`27`	`27`	`virtual void clean() {};`
	`28`	`+ void setType(int _type) { type = _type; }`
`28`	`29`	`public Q_SLOTS:`
`29`	`30`	`void process();`
`30`	`31`	`Q_SIGNALS:`
Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,8 @@ bool PWidget::execute(int type, std::unique_ptr<WalletModel::UnlockContext> pctx`
`108`	`108`	`WalletWorker* _worker = static_cast<WalletWorker*>(task->worker.data());`
`109`	`109`	`_worker->setContext(std::move(pctx));`
`110`	`110`	`}`
	`111`	`+ // Update type`
	`112`	`+ task->worker->setType(type);`
`111`	`113`	`}`
`112`	`114`	`QThreadPool::globalInstance()->start(task.data());`
`113`	`115`	`return true;`