Remove redundant NULL checks after new

practicalswift · random-zebra · commit bfd295b42863 · 2021-07-25T20:53:56.000+02:00
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -2455,7 +2455,6 @@ CBlockIndex* AddToBlockIndex(const CBlock& block)
 
     // Construct new block index object
     CBlockIndex* pindexNew = new CBlockIndex(block);
-    assert(pindexNew);
     // We assign the sequence id to blocks only when the full data is available,
     // to avoid miners withholding blocks but broadcasting headers, to get a
     // competitive advantage.
@@ -3394,8 +3393,6 @@ CBlockIndex* InsertBlockIndex(uint256 hash)
 
     // Create new
     CBlockIndex* pindexNew = new CBlockIndex();
-    if (!pindexNew)
-        throw std::runtime_error("LoadBlockIndex() : new CBlockIndex failed");
     mi = mapBlockIndex.emplace(hash, pindexNew).first;
 
     pindexNew->phashBlock = &((*mi).first);
