QA: Avoid copy of the private key in deterministicmns test

random-zebra · random-zebra · commit bcdb4f0c7e6e · 2021-11-26T11:22:07.000+01:00
diff --git a/src/test/evo_deterministicmns_tests.cpp b/src/test/evo_deterministicmns_tests.cpp
@@ -624,7 +624,7 @@ BOOST_FIXTURE_TEST_CASE(dip3_protx, TestChain400Setup)
     // ProUpReg: change voting key, operator key and payout address
     {
         const uint256& proTx = dmnHashes[InsecureRandRange(dmnHashes.size())];            // pick one at random
-        const CBLSSecretKey& new_operatorKey = GetRandomBLSKey();
+        CBLSSecretKey new_operatorKey = GetRandomBLSKey();
         const CKey& new_votingKey = GetRandomKey();
         const CScript& new_payee = GenerateRandomAddress();
         // try first with wrong owner key
@@ -652,7 +652,7 @@ BOOST_FIXTURE_TEST_CASE(dip3_protx, TestChain400Setup)
         BOOST_CHECK_MESSAGE(dmn->pdmnState->keyIDVoting == new_votingKey.GetPubKey().GetID(), "mn voting key not changed");
         BOOST_CHECK_MESSAGE(dmn->pdmnState->scriptPayout == new_payee, "mn script payout not changed");
 
-        operatorKeys.at(proTx) = new_operatorKey;
+        operatorKeys[proTx] = std::move(new_operatorKey);
 
         // check that changing the operator key puts the MN in PoSe banned state
         BOOST_CHECK_MESSAGE(dmn->pdmnState->addr == CService(), "IP address not cleared after changing operator");
