Fix subscript[0] in validation.cpp

JeremyRubin · furszy · commit b7e64a5a11df · 2021-05-08T12:51:30.000-03:00
diff --git a/src/serialize.h b/src/serialize.h
@@ -535,15 +535,15 @@ class LimitedString
         }
         string.resize(size);
         if (size != 0)
-            s.read((char*)&string[0], size);
+            s.read((char*)string.data(), size);
     }
 
     template <typename Stream>
     void Serialize(Stream& s) const
     {
         WriteCompactSize(s, string.size());
         if (!string.empty())
-            s.write((char*)&string[0], string.size());
+            s.write((char*)string.data(), string.size());
     }
 };
 
@@ -740,7 +740,7 @@ void Serialize(Stream& os, const std::basic_string<C>& str)
 {
     WriteCompactSize(os, str.size());
     if (!str.empty())
-        os.write((char*)&str[0], str.size() * sizeof(str[0]));
+        os.write((char*)str.data(), str.size() * sizeof(C));
 }
 
 template <typename Stream, typename C>
@@ -749,7 +749,7 @@ void Unserialize(Stream& is, std::basic_string<C>& str)
     unsigned int nSize = ReadCompactSize(is);
     str.resize(nSize);
     if (nSize != 0)
-        is.read((char*)&str[0], nSize * sizeof(str[0]));
+        is.read((char*)str.data(), nSize * sizeof(C));
 }
 
 /**
@@ -798,7 +798,7 @@ void Serialize_impl(Stream& os, const prevector<N, T>& v, const unsigned char&)
 {
     WriteCompactSize(os, v.size());
     if (!v.empty())
-        os.write((char*)&v[0], v.size() * sizeof(T));
+        os.write((char*)v.data(), v.size() * sizeof(T));
 }
 
 template<typename Stream, unsigned int N, typename T, typename V>
@@ -866,7 +866,7 @@ void Serialize_impl(Stream& os, const std::vector<T, A>& v, const unsigned char&
 {
     WriteCompactSize(os, v.size());
     if (!v.empty())
-        os.write((char*)&v[0], v.size() * sizeof(T));
+        os.write((char*)v.data(), v.size() * sizeof(T));
 }
 
 template <typename Stream, typename T, typename A, typename V>

Original file line number	Diff line number	Diff line change
`@@ -535,15 +535,15 @@ class LimitedString`
`535`	`535`	`}`
`536`	`536`	`string.resize(size);`
`537`	`537`	`if (size != 0)`
`538`		`- s.read((char*)&string[0], size);`
	`538`	`+ s.read((char*)string.data(), size);`
`539`	`539`	`}`
`540`	`540`
`541`	`541`	`template <typename Stream>`
`542`	`542`	`void Serialize(Stream& s) const`
`543`	`543`	`{`
`544`	`544`	`WriteCompactSize(s, string.size());`
`545`	`545`	`if (!string.empty())`
`546`		`- s.write((char*)&string[0], string.size());`
	`546`	`+ s.write((char*)string.data(), string.size());`
`547`	`547`	`}`
`548`	`548`	`};`
`549`	`549`
`@@ -740,7 +740,7 @@ void Serialize(Stream& os, const std::basic_string<C>& str)`
`740`	`740`	`{`
`741`	`741`	`WriteCompactSize(os, str.size());`
`742`	`742`	`if (!str.empty())`
`743`		`- os.write((char)&str[0], str.size() sizeof(str[0]));`
	`743`	`+ os.write((char)str.data(), str.size() sizeof(C));`
`744`	`744`	`}`
`745`	`745`
`746`	`746`	`template <typename Stream, typename C>`
`@@ -749,7 +749,7 @@ void Unserialize(Stream& is, std::basic_string<C>& str)`
`749`	`749`	`unsigned int nSize = ReadCompactSize(is);`
`750`	`750`	`str.resize(nSize);`
`751`	`751`	`if (nSize != 0)`
`752`		`- is.read((char)&str[0], nSize sizeof(str[0]));`
	`752`	`+ is.read((char)str.data(), nSize sizeof(C));`
`753`	`753`	`}`
`754`	`754`
`755`	`755`	`/**`
`@@ -798,7 +798,7 @@ void Serialize_impl(Stream& os, const prevector<N, T>& v, const unsigned char&)`
`798`	`798`	`{`
`799`	`799`	`WriteCompactSize(os, v.size());`
`800`	`800`	`if (!v.empty())`
`801`		`- os.write((char)&v[0], v.size() sizeof(T));`
	`801`	`+ os.write((char)v.data(), v.size() sizeof(T));`
`802`	`802`	`}`
`803`	`803`
`804`	`804`	`template<typename Stream, unsigned int N, typename T, typename V>`
`@@ -866,7 +866,7 @@ void Serialize_impl(Stream& os, const std::vector<T, A>& v, const unsigned char&`
`866`	`866`	`{`
`867`	`867`	`WriteCompactSize(os, v.size());`
`868`	`868`	`if (!v.empty())`
`869`		`- os.write((char)&v[0], v.size() sizeof(T));`
	`869`	`+ os.write((char)v.data(), v.size() sizeof(T));`
`870`	`870`	`}`
`871`	`871`
`872`	`872`	`template <typename Stream, typename T, typename A, typename V>`