CBase58Data::SetString: cleanse the full vector

kazcw · furszy · commit aa633c8ef59a · 2020-06-11T15:36:20.000-03:00
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.
diff --git a/src/base58.cpp b/src/base58.cpp
@@ -198,7 +198,7 @@ bool CBase58Data::SetString(const char* psz, unsigned int nVersionBytes)
     vchData.resize(vchTemp.size() - nVersionBytes);
     if (!vchData.empty())
         memcpy(&vchData[0], &vchTemp[nVersionBytes], vchData.size());
-    memory_cleanse(&vchTemp[0], vchData.size());
+    memory_cleanse(&vchTemp[0], vchTemp.size());
     return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ bool CBase58Data::SetString(const char* psz, unsigned int nVersionBytes)`
`198`	`198`	`vchData.resize(vchTemp.size() - nVersionBytes);`
`199`	`199`	`if (!vchData.empty())`
`200`	`200`	`memcpy(&vchData[0], &vchTemp[nVersionBytes], vchData.size());`
`201`		`- memory_cleanse(&vchTemp[0], vchData.size());`
	`201`	`+ memory_cleanse(&vchTemp[0], vchTemp.size());`
`202`	`202`	`return true;`
`203`	`203`	`}`
`204`	`204`