Net: Fix resource leak in ReadBinaryFile(...)

practicalswift · furszy · commit a9c922b96bd0 · 2020-04-02T02:41:09.000-03:00
Introduced in 0b6f40d via PR bitcoin#10408.
diff --git a/src/torcontrol.cpp b/src/torcontrol.cpp
@@ -378,8 +378,10 @@ static std::pair<bool,std::string> ReadBinaryFile(const std::string &filename, s
     while ((n=fread(buffer, 1, sizeof(buffer), f)) > 0) {
         // Check for reading errors so we don't return any data if we couldn't
         // read the entire file (or up to maxsize)
-        if (ferror(f))
+        if (ferror(f)) {
+            fclose(f);
             return std::make_pair(false,"");
+        }
         retval.append(buffer, buffer+n);
         if (retval.size() > maxsize)
             break;
