Explicitly initialize prevector _union

random-zebra · random-zebra · commit a8b965e5ddbf · 2020-05-17T15:19:38.000+02:00
backports bitcoin/bitcoin@1d9aa00
diff --git a/src/prevector.h b/src/prevector.h
@@ -220,13 +220,13 @@ class prevector {
         }
     }
 
-    prevector() : _size(0) {}
+    prevector() : _size(0), _union{{}} {}
 
-    explicit prevector(size_type n) : _size(0) {
+    explicit prevector(size_type n) : prevector() {
         resize(n);
     }
 
-    explicit prevector(size_type n, const T& val = T()) : _size(0) {
+    explicit prevector(size_type n, const T& val = T()) : prevector() {
         change_capacity(n);
         while (size() < n) {
             _size++;
@@ -235,7 +235,7 @@ class prevector {
     }
 
     template<typename InputIterator>
-    prevector(InputIterator first, InputIterator last) : _size(0) {
+    prevector(InputIterator first, InputIterator last) : prevector() {
         size_type n = last - first;
         change_capacity(n);
         while (first != last) {
@@ -245,7 +245,7 @@ class prevector {
         }
     }
 
-    prevector(const prevector<N, T, Size, Diff>& other) : _size(0) {
+    prevector(const prevector<N, T, Size, Diff>& other) : prevector() {
         change_capacity(other.size());
         const_iterator it = other.begin();
         while (it != other.end()) {
@@ -255,7 +255,7 @@ class prevector {
         }
     }
 
-    prevector(prevector<N, T, Size, Diff>&& other) : _size(0) {
+    prevector(prevector<N, T, Size, Diff>&& other) : prevector() {
         swap(other);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -220,13 +220,13 @@ class prevector {`
`220`	`220`	`}`
`221`	`221`	`}`
`222`	`222`
`223`		`- prevector() : _size(0) {}`
	`223`	`+ prevector() : _size(0), _union{{}} {}`
`224`	`224`
`225`		`- explicit prevector(size_type n) : _size(0) {`
	`225`	`+ explicit prevector(size_type n) : prevector() {`
`226`	`226`	`resize(n);`
`227`	`227`	`}`
`228`	`228`
`229`		`- explicit prevector(size_type n, const T& val = T()) : _size(0) {`
	`229`	`+ explicit prevector(size_type n, const T& val = T()) : prevector() {`
`230`	`230`	`change_capacity(n);`
`231`	`231`	`while (size() < n) {`
`232`	`232`	`_size++;`
`@@ -235,7 +235,7 @@ class prevector {`
`235`	`235`	`}`
`236`	`236`
`237`	`237`	`template<typename InputIterator>`
`238`		`- prevector(InputIterator first, InputIterator last) : _size(0) {`
	`238`	`+ prevector(InputIterator first, InputIterator last) : prevector() {`
`239`	`239`	`size_type n = last - first;`
`240`	`240`	`change_capacity(n);`
`241`	`241`	`while (first != last) {`
`@@ -245,7 +245,7 @@ class prevector {`
`245`	`245`	`}`
`246`	`246`	`}`
`247`	`247`
`248`		`- prevector(const prevector<N, T, Size, Diff>& other) : _size(0) {`
	`248`	`+ prevector(const prevector<N, T, Size, Diff>& other) : prevector() {`
`249`	`249`	`change_capacity(other.size());`
`250`	`250`	`const_iterator it = other.begin();`
`251`	`251`	`while (it != other.end()) {`
`@@ -255,7 +255,7 @@ class prevector {`
`255`	`255`	`}`
`256`	`256`	`}`
`257`	`257`
`258`		`- prevector(prevector<N, T, Size, Diff>&& other) : _size(0) {`
	`258`	`+ prevector(prevector<N, T, Size, Diff>&& other) : prevector() {`
`259`	`259`	`swap(other);`
`260`	`260`	`}`
`261`	`261`