[RPC][BUG] Fix 'mnfinalbudget show' returning a single budget

random-zebra · random-zebra · commit 88662848b674 · 2020-10-03T00:26:04.000+02:00
Because all of them have the same name (object key).
Fix it by adding the nHash to the object key (removing it from the
object value).
diff --git a/src/rpc/budget.cpp b/src/rpc/budget.cpp
@@ -843,7 +843,6 @@ UniValue mnfinalbudget(const JSONRPCRequest& request)
             const uint256& nHash = finalizedBudget->GetHash();
             UniValue bObj(UniValue::VOBJ);
             bObj.pushKV("FeeTX", finalizedBudget->GetFeeTXHash().ToString());
-            bObj.pushKV("Hash", nHash.ToString());
             bObj.pushKV("BlockStart", (int64_t)finalizedBudget->GetBlockStart());
             bObj.pushKV("BlockEnd", (int64_t)finalizedBudget->GetBlockEnd());
             bObj.pushKV("Proposals", finalizedBudget->GetProposalsStr());
@@ -855,7 +854,8 @@ UniValue mnfinalbudget(const JSONRPCRequest& request)
             if (!fValid)
                 bObj.pushKV("IsInvalidReason", finalizedBudget->IsInvalidReason());
 
-            resultObj.pushKV(finalizedBudget->GetName(), bObj);
+            std::string strName = strprintf("%s (%s)", finalizedBudget->GetName(), nHash.ToString());
+            resultObj.pushKV(strName, bObj);
         }
 
         return resultObj;
