Avoid asmap copies in initialization

sipa · furszy · commit 868a6edd2aaf · 2021-07-28T10:40:52.000-03:00
diff --git a/src/init.cpp b/src/init.cpp
@@ -1979,8 +1979,8 @@ bool AppInitMain()
             UIError(strprintf(_("Could not find or parse specified asmap: '%s'"), asmap_path));
             return false;
         }
-        connman.SetAsmap(asmap);
         const uint256 asmap_version = SerializeHash(asmap);
+        connman.SetAsmap(std::move(asmap));
         LogPrintf("Using asmap version %s for IP bucketing.\n", asmap_version.ToString());
     } else {
         LogPrintf("Using /16 prefix for IP bucketing.\n");
diff --git a/src/net.h b/src/net.h
@@ -271,7 +271,7 @@ class CConnman
 
     unsigned int GetReceiveFloodSize() const;
 
-    void SetAsmap(std::vector<bool> asmap) { addrman.m_asmap = asmap; }
+    void SetAsmap(std::vector<bool> asmap) { addrman.m_asmap = std::move(asmap); }
 private:
     struct ListenSocket {
         SOCKET socket;
