Rename FlushWalletDB -> CompactWalletDB, add function description

TheBlueMatt · furszy · commit 85e18f0c9c5c · 2021-01-25T08:54:37.000-03:00
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -4138,7 +4138,7 @@ void CWallet::postInitProcess(CScheduler& scheduler)
 
     // Run a thread to flush wallet periodically
     if (!CWallet::fFlushScheduled.exchange(true)) {
-        scheduler.scheduleEvery(MaybeFlushWalletDB, 500);
+        scheduler.scheduleEvery(MaybeCompactWalletDB, 500);
     }
 }
 
diff --git a/src/wallet/walletdb.cpp b/src/wallet/walletdb.cpp
@@ -891,7 +891,7 @@ DBErrors CWalletDB::ZapWalletTx(CWallet* pwallet, std::vector<CWalletTx>& vWtx)
     return DB_LOAD_OK;
 }
 
-void MaybeFlushWalletDB()
+void MaybeCompactWalletDB()
 {
     static std::atomic<bool> fOneThread;
     if (fOneThread.exchange(true)) {
diff --git a/src/wallet/walletdb.h b/src/wallet/walletdb.h
@@ -230,6 +230,7 @@ void NotifyBacked(const CWallet& wallet, bool fSuccess, std::string strMessage);
 bool BackupWallet(const CWallet& wallet, const fs::path& strDest);
 bool AttemptBackupWallet(const CWallet& wallet, const fs::path& pathSrc, const fs::path& pathDest);
 
-void MaybeFlushWalletDB();
+//! Compacts BDB state so that wallet.dat is self-contained (if there are changes)
+void MaybeCompactWalletDB();
 
 #endif // BITCOIN_WALLETDB_H

Original file line number	Diff line number	Diff line change
`@@ -4138,7 +4138,7 @@ void CWallet::postInitProcess(CScheduler& scheduler)`
`4138`	`4138`
`4139`	`4139`	`// Run a thread to flush wallet periodically`
`4140`	`4140`	`if (!CWallet::fFlushScheduled.exchange(true)) {`
`4141`		`- scheduler.scheduleEvery(MaybeFlushWalletDB, 500);`
	`4141`	`+ scheduler.scheduleEvery(MaybeCompactWalletDB, 500);`
`4142`	`4142`	`}`
`4143`	`4143`	`}`
`4144`	`4144`
Original file line number	Diff line number	Diff line change
`@@ -891,7 +891,7 @@ DBErrors CWalletDB::ZapWalletTx(CWallet* pwallet, std::vector<CWalletTx>& vWtx)`
`891`	`891`	`return DB_LOAD_OK;`
`892`	`892`	`}`
`893`	`893`
`894`		`-void MaybeFlushWalletDB()`
	`894`	`+void MaybeCompactWalletDB()`
`895`	`895`	`{`
`896`	`896`	`static std::atomic<bool> fOneThread;`
`897`	`897`	`if (fOneThread.exchange(true)) {`