[BUG][TierTwo] Clear fulfilled requests when mnsync fails

random-zebra · furszy · commit 754177e25d45 · 2021-09-19T14:06:44.000-03:00
the current asset should be checked, not the "next" one. Github-Pull: #2559 Rebased-From: db36fb8
diff --git a/src/masternode-sync.cpp b/src/masternode-sync.cpp
@@ -185,11 +185,13 @@ int CMasternodeSync::GetNextAsset(int currentAsset)
 
 void CMasternodeSync::SwitchToNextAsset()
 {
+    if (RequestedMasternodeAssets == MASTERNODE_SYNC_INITIAL ||
+            RequestedMasternodeAssets == MASTERNODE_SYNC_FAILED) {
+        ClearFulfilledRequest();
+    }
     const int nextAsset = GetNextAsset(RequestedMasternodeAssets);
     if (nextAsset == MASTERNODE_SYNC_FINISHED) {
         LogPrintf("%s - Sync has finished\n", __func__);
-    } else if (nextAsset == MASTERNODE_SYNC_FAILED) {
-        ClearFulfilledRequest();
     }
     RequestedMasternodeAssets = nextAsset;
     RequestedMasternodeAttempt = 0;
