refactor: Replace magic number with named constant

hebasto · Fuzzbawls · commit 7532090bfdde · 2021-06-13T23:23:29.000-07:00
diff --git a/src/mapport.cpp b/src/mapport.cpp
@@ -35,6 +35,9 @@ static_assert(MINIUPNPC_API_VERSION >= 10, "miniUPnPc API version >= 10 assumed"
 #ifdef USE_UPNP
 static CThreadInterrupt g_upnp_interrupt;
 static std::thread g_upnp_thread;
+
+static constexpr auto PORT_MAPPING_REANNOUNCE_PERIOD = std::chrono::minutes(20);
+
 void ThreadMapPort()
 {
     std::string port = strprintf("%u", GetListenPort());
@@ -84,7 +87,7 @@ void ThreadMapPort()
             } else {
                 LogPrintf("UPnP Port Mapping successful.\n");
             }
-        } while(g_upnp_interrupt.sleep_for(std::chrono::minutes(20)));
+        } while(g_upnp_interrupt.sleep_for(PORT_MAPPING_REANNOUNCE_PERIOD));
 
         r = UPNP_DeletePortMapping(urls.controlURL, data.first.servicetype, port.c_str(), "TCP", 0);
         LogPrintf("UPNP_DeletePortMapping() returned: %d\n", r);
