[Trivial] Unitialized scalar fields and variables

random-zebra · random-zebra · commit 6cf3c8f14ffc · 2021-02-13T15:45:32.000+01:00
diff --git a/src/blockassembler.cpp b/src/blockassembler.cpp
@@ -305,7 +305,7 @@ void BlockAssembler::AddToBlock(CTxMemPool::txiter iter)
     bool fPrintPriority = gArgs.GetBoolArg("-printpriority", defaultPrintPriority);
     if (fPrintPriority) {
         double dPriority = iter->GetPriority(nHeight);
-        CAmount dummy;
+        CAmount dummy{0};
         mempool.ApplyDeltas(iter->GetTx().GetHash(), dPriority, dummy);
         LogPrintf("priority %.1f fee %s txid %s\n",
                   dPriority,
@@ -390,7 +390,7 @@ void BlockAssembler::addPriorityTxs()
     for (CTxMemPool::indexed_transaction_set::iterator mi = mempool.mapTx.begin();
          mi != mempool.mapTx.end(); ++mi) {
         double dPriority = mi->GetPriority(nHeight);
-        CAmount dummy;
+        CAmount dummy{0};
         mempool.ApplyDeltas(mi->GetSharedTx()->GetHash(), dPriority, dummy);
         vecPriority.emplace_back(TxCoinAgePriority(dPriority, mi));
     }
diff --git a/src/blockassembler.h b/src/blockassembler.h
@@ -36,10 +36,10 @@ class BlockAssembler
     // The constructed block template
     std::unique_ptr<CBlockTemplate> pblocktemplate;
     // A convenience pointer that always refers to the CBlock in pblocktemplate
-    CBlock* pblock;
+    CBlock* pblock{nullptr};
 
     // Configuration parameters for the block size
-    unsigned int nBlockMaxSize, nBlockMinSize;
+    unsigned int nBlockMaxSize{0}, nBlockMinSize{0};
 
     // Information on the current status of the block
     uint64_t nBlockSize{0};
@@ -57,10 +57,10 @@ class BlockAssembler
     bool blockFinished{false};
 
     // Keep track of block space used for shield txes
-    unsigned int nSizeShielded = 0;
+    unsigned int nSizeShielded{0};
 
     // Whether should print priority by default or not
-    const bool defaultPrintPriority;
+    const bool defaultPrintPriority{false};
 
 public:
     BlockAssembler(const CChainParams& chainparams, const bool defaultPrintPriority);
diff --git a/src/httpserver.cpp b/src/httpserver.cpp
@@ -169,9 +169,9 @@ struct HTTPPathHandler
         prefix(prefix), exactMatch(exactMatch), handler(handler)
     {
     }
-    std::string prefix;
-    bool exactMatch;
-    HTTPRequestHandler handler;
+    std::string prefix{};
+    bool exactMatch{false};
+    HTTPRequestHandler handler{};
 };
 
 /** HTTP module state */
diff --git a/src/libzerocoin/CoinSpend.h b/src/libzerocoin/CoinSpend.h
@@ -148,17 +148,17 @@ class CoinSpend
     }
 
 protected:
-    CoinDenomination denomination = ZQ_ERROR;
-    CBigNum coinSerialNumber;
-    uint8_t version;
+    CoinDenomination denomination{ZQ_ERROR};
+    CBigNum coinSerialNumber{};
+    uint8_t version{0};
     //As of version 2
     CPubKey pubkey;
     std::vector<unsigned char> vchSig;
-    SpendType spendType;
-    uint256 ptxHash;
+    SpendType spendType{SPEND};
+    uint256 ptxHash{UINT256_ZERO};
 
 private:
-    uint32_t accChecksum;
+    uint32_t accChecksum{0};
     CBigNum accCommitmentToCoinValue;
     CBigNum serialCommitmentToCoinValue;
     AccumulatorProofOfKnowledge accumulatorPoK;
diff --git a/src/net.h b/src/net.h
@@ -329,22 +329,22 @@ class CConnman
     // Network usage totals
     RecursiveMutex cs_totalBytesRecv;
     RecursiveMutex cs_totalBytesSent;
-    uint64_t nTotalBytesRecv;
-    uint64_t nTotalBytesSent;
+    uint64_t nTotalBytesRecv{0};
+    uint64_t nTotalBytesSent{0};
 
     // Whitelisted ranges. Any node connecting from these is automatically
     // whitelisted (as well as those connecting to whitelisted binds).
     std::vector<CSubNet> vWhitelistedRange;
     RecursiveMutex cs_vWhitelistedRange;
 
-    unsigned int nSendBufferMaxSize;
-    unsigned int nReceiveFloodSize;
+    unsigned int nSendBufferMaxSize{0};
+    unsigned int nReceiveFloodSize{0};
 
     std::vector<ListenSocket> vhListenSocket;
     banmap_t setBanned;
     RecursiveMutex cs_setBanned;
-    bool setBannedIsDirty;
-    bool fAddressesInitialized;
+    bool setBannedIsDirty{false};
+    bool fAddressesInitialized{false};
     CAddrMan addrman;
     std::deque<std::string> vOneShots;
     RecursiveMutex cs_vOneShots;
@@ -356,23 +356,23 @@ class CConnman
     std::atomic<NodeId> nLastNodeId;
 
     /** Services this instance offers */
-    ServiceFlags nLocalServices;
+    ServiceFlags nLocalServices{NODE_NONE};
 
     /** Services this instance cares about */
-    ServiceFlags nRelevantServices;
+    ServiceFlags nRelevantServices{NODE_NONE};
 
-    CSemaphore *semOutbound;
-    int nMaxConnections;
-    int nMaxOutbound;
-    int nMaxFeeler;
+    CSemaphore *semOutbound{nullptr};
+    int nMaxConnections{0};
+    int nMaxOutbound{0};
+    int nMaxFeeler{0};
     std::atomic<int> nBestHeight;
-    CClientUIInterface* clientInterface;
+    CClientUIInterface* clientInterface{nullptr};
 
     /** SipHasher seeds for deterministic randomness */
-    const uint64_t nSeed0, nSeed1;
+    const uint64_t nSeed0{0}, nSeed1{0};
 
     /** flag for waking the message processor. */
-    bool fMsgProcWake;
+    bool fMsgProcWake{false};
 
     std::condition_variable condMsgProc;
     std::mutex mutexMsgProc;
diff --git a/src/netaddress.h b/src/netaddress.h
@@ -30,7 +30,7 @@ class CNetAddr
 {
 protected:
     unsigned char ip[16]; // in network byte order
-    uint32_t scopeId;     // for scoped/link-local ipv6 addresses
+    uint32_t scopeId{0};     // for scoped/link-local ipv6 addresses
 
 public:
     CNetAddr();
diff --git a/src/policy/fees.h b/src/policy/fees.h
@@ -96,7 +96,7 @@ class TxConfirmStats
     // Combine the conf counts with tx counts to calculate the confirmation % for each Y,X
     // Combine the total value with the tx counts to calculate the avg feerate per bucket
 
-    double decay;
+    double decay{0.0};
 
     // Mempool counts of outstanding transactions
     // For each bucket X, track the number of transactions in the mempool
diff --git a/src/qt/pivx/receivedialog.h b/src/qt/pivx/receivedialog.h
@@ -27,9 +27,9 @@ class ReceiveDialog : public FocusedDialog
 private Q_SLOTS:
     void onCopy();
 private:
-    Ui::ReceiveDialog *ui;
-    QPixmap *qrImage;
-    SendCoinsRecipient *info = nullptr;
+    Ui::ReceiveDialog *ui{nullptr};
+    QPixmap *qrImage{nullptr};
+    SendCoinsRecipient *info{nullptr};
 };
 
 #endif // RECEIVEDIALOG_H
diff --git a/src/random.h b/src/random.h
@@ -44,14 +44,14 @@ void GetStrongRandBytes(unsigned char* buf, int num);
  */
 class FastRandomContext {
 private:
-    bool requires_seed;
+    bool requires_seed{false};
     ChaCha20 rng;
 
     unsigned char bytebuf[64];
-    int bytebuf_size;
+    int bytebuf_size{0};
 
-    uint64_t bitbuf;
-    int bitbuf_size;
+    uint64_t bitbuf{0};
+    int bitbuf_size{0};
 
     void RandomSeed();
 
diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp
@@ -679,15 +679,13 @@ UniValue getsupplyinfo(const JSONRPCRequest& request)
 
 struct CCoinsStats
 {
-    int nHeight;
-    uint256 hashBlock;
-    uint64_t nTransactions;
-    uint64_t nTransactionOutputs;
-    uint256 hashSerialized;
-    uint64_t nDiskSize;
-    CAmount nTotalAmount;
-
-    CCoinsStats() : nHeight(0), nTransactions(0), nTransactionOutputs(0), nTotalAmount(0) {}
+    int nHeight{0};
+    uint256 hashBlock{UINT256_ZERO};
+    uint64_t nTransactions{0};
+    uint64_t nTransactionOutputs{0};
+    uint256 hashSerialized{UINT256_ZERO};
+    uint64_t nDiskSize{0};
+    CAmount nTotalAmount{0};
 };
 
 static void ApplyStats(CCoinsStats &stats, CHashWriter& ss, const uint256& hash, const std::map<uint32_t, Coin>& outputs)
diff --git a/src/rpc/server.h b/src/rpc/server.h
@@ -37,7 +37,7 @@ struct UniValueType {
     UniValueType(UniValue::VType _type) : typeAny(false), type(_type) {}
     UniValueType() : typeAny(true) {}
     bool typeAny;
-    UniValue::VType type;
+    UniValue::VType type{UniValue::VNULL};
 };
 
 class JSONRPCRequest
diff --git a/src/zmq/zmqpublishnotifier.h b/src/zmq/zmqpublishnotifier.h
@@ -12,7 +12,7 @@ class CBlockIndex;
 class CZMQAbstractPublishNotifier : public CZMQAbstractNotifier
 {
 private:
-    uint32_t nSequence; // upcounting per message sequence number
+    uint32_t nSequence{0}; // upcounting per message sequence number
 
 public:
 
diff --git a/src/zpiv/zpos.h b/src/zpiv/zpos.h
@@ -11,9 +11,9 @@
 class CLegacyZPivStake : public CStakeInput
 {
 private:
-    uint32_t nChecksum;
-    libzerocoin::CoinDenomination denom;
-    uint256 hashSerial;
+    uint32_t nChecksum{0};
+    libzerocoin::CoinDenomination denom{libzerocoin::ZQ_ERROR};
+    uint256 hashSerial{UINT256_ZERO};
 
 public:
     CLegacyZPivStake() : CStakeInput(nullptr) {}

Original file line number	Diff line number	Diff line change
`@@ -169,9 +169,9 @@ struct HTTPPathHandler`
`169`	`169`	`prefix(prefix), exactMatch(exactMatch), handler(handler)`
`170`	`170`	`{`
`171`	`171`	`}`
`172`		`- std::string prefix;`
`173`		`- bool exactMatch;`
`174`		`- HTTPRequestHandler handler;`
	`172`	`+ std::string prefix{};`
	`173`	`+ bool exactMatch{false};`
	`174`	`+ HTTPRequestHandler handler{};`
`175`	`175`	`};`
`176`	`176`
`177`	`177`	`/** HTTP module state */`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class CNetAddr`
`30`	`30`	`{`
`31`	`31`	`protected:`
`32`	`32`	`unsigned char ip[16]; // in network byte order`
`33`		`- uint32_t scopeId; // for scoped/link-local ipv6 addresses`
	`33`	`+ uint32_t scopeId{0}; // for scoped/link-local ipv6 addresses`
`34`	`34`
`35`	`35`	`public:`
`36`	`36`	`CNetAddr();`