[Qt] Properly set involvesWatchAddress in the transaction record

Fuzzbawls · Fuzzbawls · commit 6b0b6d0df562 · 2018-04-08T18:23:59.000-07:00
This prevents "the eye" from watching you when it shouldn't
diff --git a/src/qt/transactionfilterproxy.h b/src/qt/transactionfilterproxy.h
@@ -24,8 +24,8 @@ class TransactionFilterProxy : public QSortFilterProxyModel
     static const QDateTime MAX_DATE;
     /** Type filter bit field (all types) */
     static const quint32 ALL_TYPES = 0xFFFFFFFF;
-    /** Type filter bit field (all types but Obfuscation-SPAM ... enum 0-13 are common) */
-    static const quint32 COMMON_TYPES = 0x000003FFF;
+    /** Type filter bit field (all types but Obfuscation-SPAM ... enum 0-14 are common) */
+    static const quint32 COMMON_TYPES = 0x0005FFFF;
 
     static quint32 TYPE(int type) { return 1 << type; }
 
diff --git a/src/qt/transactionrecord.cpp b/src/qt/transactionrecord.cpp
@@ -119,6 +119,7 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(const CWallet*
             isminetype mine = wallet->IsMine(txout);
             if (mine) {
                 TransactionRecord sub(hash, nTime);
+                sub.involvesWatchAddress = mine & ISMINE_WATCH_ONLY;
                 if (fZSpendFromMe) {
                     sub.type = TransactionRecord::ZerocoinSpend_FromMe;
                 } else {
@@ -139,6 +140,7 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(const CWallet*
 
             // zerocoin spend that was sent to someone else
             TransactionRecord sub(hash, nTime);
+            sub.involvesWatchAddress = mine & ISMINE_WATCH_ONLY;
             sub.debit = -txout.nValue;
             sub.type = TransactionRecord::ZerocoinSpend;
             sub.address = mapValue["zerocoinspend"];
