[validation] Remove pool member from ConnectTrace

jnewbery · furszy · commit 5cc619fe9d8d · 2021-04-13T12:38:39.000-03:00
It's no longer used for anything.
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -2023,12 +2023,9 @@ struct PerBlockConnectTrace {
 class ConnectTrace {
 private:
     std::vector<PerBlockConnectTrace> blocksConnected;
-    CTxMemPool &pool;
 
 public:
-    ConnectTrace(CTxMemPool &_pool) : blocksConnected(1), pool(_pool) {}
-
-    ~ConnectTrace() {}
+    ConnectTrace() : blocksConnected(1) {}
 
     void BlockConnected(CBlockIndex* pindex, std::shared_ptr<const CBlock> pblock) {
         assert(!blocksConnected.back().pindex);
@@ -2330,7 +2327,7 @@ bool ActivateBestChain(CValidationState& state, std::shared_ptr<const CBlock> pb
             do {
                 // We absolutely may not unlock cs_main until we've made forward progress
                 // (with the exception of shutdown due to hardware issues, low disk space, etc).
-                ConnectTrace connectTrace(mempool); // Destructed before cs_main is unlocked
+                ConnectTrace connectTrace; // Destructed before cs_main is unlocked
 
                 if (pindexMostWork == nullptr) {
                     pindexMostWork = FindMostWorkChain();
