Wallet/RPC: Use filename rather than CWallet pointer, for lockwallet

luke-jr · random-zebra · commit 3bfa7d8870d1 · 2021-05-17T13:28:11.000+02:00
RPCRunLater job name

The job name is logged, and could pose as an information leak to someone
attacking the process, helping them counteract ASLR protections
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -3427,7 +3427,7 @@ UniValue walletpassphrase(const JSONRPCRequest& request)
 
     if (nSleepTime > 0) {
         pwallet->nRelockTime = GetTime () + nSleepTime;
-        RPCRunLater ("lockwallet", std::bind (LockWallet, pwallet), nSleepTime);
+        RPCRunLater (strprintf("lockwallet(%s)", pwallet->GetName()), std::bind (LockWallet, pwallet), nSleepTime);
     }
 
     return NullUniValue;

Original file line number	Diff line number	Diff line change
`@@ -3427,7 +3427,7 @@ UniValue walletpassphrase(const JSONRPCRequest& request)`
`3427`	`3427`
`3428`	`3428`	`if (nSleepTime > 0) {`
`3429`	`3429`	`pwallet->nRelockTime = GetTime () + nSleepTime;`
`3430`		`- RPCRunLater ("lockwallet", std::bind (LockWallet, pwallet), nSleepTime);`
	`3430`	`+ RPCRunLater (strprintf("lockwallet(%s)", pwallet->GetName()), std::bind (LockWallet, pwallet), nSleepTime);`
`3431`	`3431`	`}`
`3432`	`3432`
`3433`	`3433`	`return NullUniValue;`