[GUI][Performance] Optimizations to every list view load in the GUI.

furszy · Fuzzbawls · commit 3b67bc69db47 · 2020-01-11T15:42:51.000-08:00
Batching items load + uniform item sizes. Github-Pull: #1217 Rebased-From: 7c9dd0d
diff --git a/src/qt/pivx/addresseswidget.cpp b/src/qt/pivx/addresseswidget.cpp
@@ -94,6 +94,7 @@ AddressesWidget::AddressesWidget(PIVXGUI* parent) :
     ui->listAddresses->setMinimumHeight(NUM_ITEMS * (DECORATION_SIZE + 2));
     ui->listAddresses->setAttribute(Qt::WA_MacShowFocusRect, false);
     ui->listAddresses->setSelectionBehavior(QAbstractItemView::SelectRows);
+    ui->listAddresses->setUniformItemSizes(true);
 
     //Empty List
     ui->emptyContainer->setVisible(false);
diff --git a/src/qt/pivx/coldstakingwidget.cpp b/src/qt/pivx/coldstakingwidget.cpp
@@ -185,6 +185,7 @@ ColdStakingWidget::ColdStakingWidget(PIVXGUI* parent) :
     ui->listViewStakingAddress->setMinimumHeight(NUM_ITEMS * (DECORATION_SIZE + 2));
     ui->listViewStakingAddress->setAttribute(Qt::WA_MacShowFocusRect, false);
     ui->listViewStakingAddress->setSelectionBehavior(QAbstractItemView::SelectRows);
+    ui->listViewStakingAddress->setUniformItemSizes(true);
 
     connect(ui->pushButtonSend, &QPushButton::clicked, this, &ColdStakingWidget::onSendClicked);
     connect(btnOwnerContact, &QAction::triggered, [this](){ onContactsClicked(true); });
diff --git a/src/qt/pivx/dashboardwidget.cpp b/src/qt/pivx/dashboardwidget.cpp
@@ -124,6 +124,9 @@ DashboardWidget::DashboardWidget(PIVXGUI* parent) :
     ui->listTransactions->setMinimumHeight(NUM_ITEMS * (DECORATION_SIZE + 2));
     ui->listTransactions->setAttribute(Qt::WA_MacShowFocusRect, false);
     ui->listTransactions->setSelectionBehavior(QAbstractItemView::SelectRows);
+    ui->listTransactions->setLayoutMode(QListView::LayoutMode::Batched);
+    ui->listTransactions->setBatchSize(50);
+    ui->listTransactions->setUniformItemSizes(true);
 
     // Sync Warning
     ui->layoutWarning->setVisible(true);
diff --git a/src/qt/pivx/privacywidget.cpp b/src/qt/pivx/privacywidget.cpp
@@ -158,6 +158,9 @@ PrivacyWidget::PrivacyWidget(PIVXGUI* parent) :
     ui->listView->setMinimumHeight(NUM_ITEMS * (DECORATION_SIZE + 2));
     ui->listView->setAttribute(Qt::WA_MacShowFocusRect, false);
     ui->listView->setSelectionBehavior(QAbstractItemView::SelectRows);
+    ui->listView->setLayoutMode(QListView::LayoutMode::Batched);
+    ui->listView->setBatchSize(30);
+    ui->listView->setUniformItemSizes(true);
 }
 
 void PrivacyWidget::loadWalletModel(){
diff --git a/src/qt/pivx/receivewidget.cpp b/src/qt/pivx/receivewidget.cpp
@@ -84,6 +84,7 @@ ReceiveWidget::ReceiveWidget(PIVXGUI* parent) :
     ui->listViewAddress->setMinimumHeight(NUM_ITEMS * (DECORATION_SIZE + 2));
     ui->listViewAddress->setAttribute(Qt::WA_MacShowFocusRect, false);
     ui->listViewAddress->setSelectionBehavior(QAbstractItemView::SelectRows);
+    ui->listViewAddress->setUniformItemSizes(true);
 
     spacer = new QSpacerItem(40, 20, QSizePolicy::Maximum, QSizePolicy::Expanding);
     ui->btnMyAddresses->setChecked(true);

Original file line number	Diff line number	Diff line change
`@@ -158,6 +158,9 @@ PrivacyWidget::PrivacyWidget(PIVXGUI* parent) :`
`158`	`158`	`ui->listView->setMinimumHeight(NUM_ITEMS * (DECORATION_SIZE + 2));`
`159`	`159`	`ui->listView->setAttribute(Qt::WA_MacShowFocusRect, false);`
`160`	`160`	`ui->listView->setSelectionBehavior(QAbstractItemView::SelectRows);`
	`161`	`+ ui->listView->setLayoutMode(QListView::LayoutMode::Batched);`
	`162`	`+ ui->listView->setBatchSize(30);`
	`163`	`+ ui->listView->setUniformItemSizes(true);`
`161`	`164`	`}`
`162`	`165`
`163`	`166`	`void PrivacyWidget::loadWalletModel(){`