[Wallet] GetAvailableP2CSCoins, a p2cs utxo is spendable only if IsMine == ISMINE_SPENDABLE_DELEGATED.

furszy · furszy · commit 3359aa71c416 · 2019-11-08T18:24:49.000-03:00
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -1934,9 +1934,10 @@ void CWallet::GetAvailableP2CSCoins(std::vector<COutput>& vCoins) const {
 
                     if (utxo.scriptPubKey.IsPayToColdStaking()) {
                         isminetype mine = IsMine(utxo);
-                        if (mine & ISMINE_COLD || mine & ISMINE_SPENDABLE_DELEGATED)
+                        bool isMineSpendable = mine & ISMINE_SPENDABLE_DELEGATED;
+                        if (mine & ISMINE_COLD || isMineSpendable)
                             // Depth is not used, no need waste resources and set it for now.
-                            vCoins.emplace_back(COutput(pcoin, i, 0, true));
+                            vCoins.emplace_back(COutput(pcoin, i, 0, isMineSpendable));
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -1934,9 +1934,10 @@ void CWallet::GetAvailableP2CSCoins(std::vector<COutput>& vCoins) const {`
`1934`	`1934`
`1935`	`1935`	`if (utxo.scriptPubKey.IsPayToColdStaking()) {`
`1936`	`1936`	`isminetype mine = IsMine(utxo);`
`1937`		`- if (mine & ISMINE_COLD \|\| mine & ISMINE_SPENDABLE_DELEGATED)`
	`1937`	`+ bool isMineSpendable = mine & ISMINE_SPENDABLE_DELEGATED;`
	`1938`	`+ if (mine & ISMINE_COLD \|\| isMineSpendable)`
`1938`	`1939`	`// Depth is not used, no need waste resources and set it for now.`
`1939`		`- vCoins.emplace_back(COutput(pcoin, i, 0, true));`
	`1940`	`+ vCoins.emplace_back(COutput(pcoin, i, 0, isMineSpendable));`
`1940`	`1941`	`}`
`1941`	`1942`	`}`
`1942`	`1943`	`}`