fuzz: Remove option --export_coverage from test_runner

MarcoFalke · furszy · commit 320587186164 · 2021-05-26T12:17:30.000-03:00
The coverage statistics are not stable across clang versions
diff --git a/test/fuzz/test_runner.py b/test/fuzz/test_runner.py
@@ -25,11 +25,6 @@ def main():
         default="INFO",
         help="log events at this level and higher to the console. Can be set to DEBUG, INFO, WARNING, ERROR or CRITICAL. Passing --loglevel DEBUG will output all logs to console.",
     )
-    parser.add_argument(
-        '--export_coverage',
-        action='store_true',
-        help='If true, export coverage information to files in the seed corpus',
-    )
     parser.add_argument(
         'seed_dir',
         help='The seed corpus to run on (must contain subfolders for each fuzz target).',
@@ -109,7 +104,6 @@ def main():
         corpus=args.seed_dir,
         test_list=test_list_selection,
         build_dir=config["environment"]["BUILDDIR"],
-        export_coverage=args.export_coverage,
     )
 
 
@@ -129,7 +123,7 @@ def merge_inputs(*, corpus, test_list, build_dir, merge_dir):
         logging.debug('Output: {}'.format(output))
 
 
-def run_once(*, corpus, test_list, build_dir, export_coverage):
+def run_once(*, corpus, test_list, build_dir):
     for t in test_list:
         args = [
             os.path.join(build_dir, 'src', 'test', 'fuzz', t),
@@ -149,13 +143,6 @@ def run_once(*, corpus, test_list, build_dir, export_coverage):
                 logging.info(e.stderr)
             logging.info("Target \"{}\" failed with exit code {}: {}".format(t, e.returncode, " ".join(args)))
             sys.exit(1)
-        if not export_coverage:
-            continue
-        for l in output.splitlines():
-            if 'INITED' in l:
-                with open(os.path.join(corpus, t + '_coverage'), 'w', encoding='utf-8') as cov_file:
-                    cov_file.write(l)
-                    break
 
 
 def parse_test_list(makefile):
