GetShieldedSpendsHash & GetShieldedOutputsHash assert txTo.sapData existence.

furszy · furszy · commit 2fff9ec9299f · 2020-09-21T20:00:34.000-03:00
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
@@ -1125,6 +1125,7 @@ uint256 GetOutputsHash(const CTransaction& txTo) {
 }
 
 uint256 GetShieldedSpendsHash(const CTransaction& txTo) {
+    assert(txTo.sapData);
     CBLAKE2bWriter ss(SER_GETHASH, 0, PIVX_SHIELDED_SPENDS_HASH_PERSONALIZATION);
     auto sapData = txTo.sapData;
     for (const auto& n : sapData->vShieldedSpend) {
@@ -1138,6 +1139,7 @@ uint256 GetShieldedSpendsHash(const CTransaction& txTo) {
 }
 
 uint256 GetShieldedOutputsHash(const CTransaction& txTo) {
+    assert(txTo.sapData);
     CBLAKE2bWriter ss(SER_GETHASH, 0, PIVX_SHIELDED_OUTPUTS_HASH_PERSONALIZATION);
     auto sapData = txTo.sapData;
     for (const auto& n : sapData->vShieldedOutput) {

Original file line number	Diff line number	Diff line change
`@@ -1125,6 +1125,7 @@ uint256 GetOutputsHash(const CTransaction& txTo) {`
`1125`	`1125`	`}`
`1126`	`1126`
`1127`	`1127`	`uint256 GetShieldedSpendsHash(const CTransaction& txTo) {`
	`1128`	`+ assert(txTo.sapData);`
`1128`	`1129`	`CBLAKE2bWriter ss(SER_GETHASH, 0, PIVX_SHIELDED_SPENDS_HASH_PERSONALIZATION);`
`1129`	`1130`	`auto sapData = txTo.sapData;`
`1130`	`1131`	`for (const auto& n : sapData->vShieldedSpend) {`
`@@ -1138,6 +1139,7 @@ uint256 GetShieldedSpendsHash(const CTransaction& txTo) {`
`1138`	`1139`	`}`
`1139`	`1140`
`1140`	`1141`	`uint256 GetShieldedOutputsHash(const CTransaction& txTo) {`
	`1142`	`+ assert(txTo.sapData);`
`1141`	`1143`	`CBLAKE2bWriter ss(SER_GETHASH, 0, PIVX_SHIELDED_OUTPUTS_HASH_PERSONALIZATION);`
`1142`	`1144`	`auto sapData = txTo.sapData;`
`1143`	`1145`	`for (const auto& n : sapData->vShieldedOutput) {`