Solving a dead end inconsistency over the masternode activation process.

furszy · furszy · commit 2e3e3130c41d · 2020-10-03T11:07:53.000-03:00
A valid masternode is created, mn start message is broadcasted and the entire network receives it. Peers move the masternode status to pre_enable (active) and are waiting for a mn ping update to fulfill the min ping time requirement after it activation to move to enable.

Issue:

As the mnping update message work flow is not performing any action until the masternode is in enable status (masternode.cpp, line 707), the masternode ping is never updated, there by the masternode will never be moved to enable status.
diff --git a/src/masternode.cpp b/src/masternode.cpp
@@ -704,7 +704,11 @@ bool CMasternodePing::CheckAndUpdate(int& nDos, bool fRequireEnabled, bool fChec
     LogPrint(BCLog::MNPING, "%s: New Ping - %s - %s - %lli\n", __func__, GetHash().ToString(), blockHash.ToString(), sigTime);
 
     if (isMasternodeFound && pmn->protocolVersion >= ActiveProtocol()) {
-        if (fRequireEnabled && !pmn->IsEnabled()) return false;
+
+        // Update ping only if the masternode is active/enabled
+        if (fRequireEnabled && (!pmn->IsEnabled() && !pmn->IsPreEnabled())) {
+            return false;
+        }
 
         // update only if there is no known ping for this masternode or
         // last ping was more then MASTERNODE_MIN_MNP_SECONDS-60 ago comparing to this one
diff --git a/src/masternode.h b/src/masternode.h
@@ -244,6 +244,11 @@ class CMasternode : public CSignedMessage
         return WITH_LOCK(cs, return activeState == MASTERNODE_ENABLED);
     }
 
+    bool IsPreEnabled()
+    {
+        return WITH_LOCK(cs, return activeState == MASTERNODE_PRE_ENABLED );
+    }
+
     std::string Status()
     {
         std::string strStatus = "ACTIVE";

Original file line number	Diff line number	Diff line change
`@@ -244,6 +244,11 @@ class CMasternode : public CSignedMessage`
`244`	`244`	`return WITH_LOCK(cs, return activeState == MASTERNODE_ENABLED);`
`245`	`245`	`}`
`246`	`246`
	`247`	`+ bool IsPreEnabled()`
	`248`	`+ {`
	`249`	`+ return WITH_LOCK(cs, return activeState == MASTERNODE_PRE_ENABLED );`
	`250`	`+ }`
	`251`	`+`
`247`	`252`	`std::string Status()`
`248`	`253`	`{`
`249`	`254`	`std::string strStatus = "ACTIVE";`