RPC: fix mnconnect when first param is missing

random-zebra · random-zebra · commit 21dedda692a4 · 2022-02-16T12:57:11.000+01:00
diff --git a/src/rpc/misc.cpp b/src/rpc/misc.cpp
@@ -772,7 +772,7 @@ const char* CLEAR_CONN = "clear_conn";
 **/
 UniValue mnconnect(const JSONRPCRequest& request)
 {
-    if (request.fHelp || request.params.size() > 4) {
+    if (request.fHelp || request.params.empty() || request.params.size() > 4) {
         throw std::runtime_error(
                 "mnconnect \"op_type\" (\"[pro_tx_hash, pro_tx_hash,..]\" llmq_type \"quorum_hash\")\n"
                 "\nAdd manual quorum members connections for internal testing purposes of the tier two p2p network layer\n"

Original file line number	Diff line number	Diff line change
`@@ -772,7 +772,7 @@ const char* CLEAR_CONN = "clear_conn";`
`772`	`772`	`**/`
`773`	`773`	`UniValue mnconnect(const JSONRPCRequest& request)`
`774`	`774`	`{`
`775`		`- if (request.fHelp \|\| request.params.size() > 4) {`
	`775`	`+ if (request.fHelp \|\| request.params.empty() \|\| request.params.size() > 4) {`
`776`	`776`	`throw std::runtime_error(`
`777`	`777`	`"mnconnect \"op_type\" (\"[pro_tx_hash, pro_tx_hash,..]\" llmq_type \"quorum_hash\")\n"`
`778`	`778`	`"\nAdd manual quorum members connections for internal testing purposes of the tier two p2p network layer\n"`