[Wallet] Close DB on error

Fuzzbawls · Fuzzbawls · commit 0c4b20f3f058 · 2021-02-06T20:31:07.000-08:00
diff --git a/src/wallet/db.cpp b/src/wallet/db.cpp
@@ -104,8 +104,10 @@ bool CDBEnv::Open(const fs::path& pathIn)
             DB_RECOVER |
             nEnvFlags,
         S_IRUSR | S_IWUSR);
-    if (ret != 0)
+    if (ret != 0) {
+        dbenv->close(0);
         return error("CDBEnv::Open : Error %d opening database environment: %s\n", ret, DbEnv::strerror(ret));
+    }
 
     fDbEnvInit = true;
     fMockDb = false;
@@ -199,6 +201,7 @@ bool CDB::Recover(const std::string& filename, void *callbackDataIn, bool (*reco
                             0);
     if (ret > 0) {
         LogPrintf("Cannot create database file %s\n", filename);
+        pdbCopy->close(0);
         return false;
     }
 
@@ -533,8 +536,10 @@ bool CDB::Rewrite(CWalletDBWrapper& dbw, const char* pszSkip)
                         env->CloseDb(strFile);
                         if (pdbCopy->close(0))
                             fSuccess = false;
-                        delete pdbCopy;
+                    } else {
+                        pdbCopy->close(0);
                     }
+                    delete pdbCopy;
                 }
                 if (fSuccess) {
                     Db dbA(env->dbenv, 0);
