Cleanup successful sessions before doing timeout check (#2712)

codablock · panleone · commit 0613978bfd9a · 2024-10-29T15:43:24.000+01:00
Otherwise we get some false-positive timeout messages in logs.
diff --git a/src/llmq/quorums_signing_shares.cpp b/src/llmq/quorums_signing_shares.cpp
@@ -930,6 +930,20 @@ void CSigSharesManager::Cleanup()
     {
         LOCK(cs);
 
+        // Remove sessions which were successfully recovered
+        std::unordered_set<uint256> doneSessions;
+        sigShares.ForEach([&](const SigShareKey& k, const CSigShare& sigShare) {
+            if (doneSessions.count(sigShare.GetSignHash())) {
+                return;
+            }
+            if (quorumSigningManager->HasRecoveredSigForSession(sigShare.GetSignHash())) {
+                doneSessions.emplace(sigShare.GetSignHash());
+            }
+        });
+        for (auto& signHash : doneSessions) {
+            RemoveSigSharesForSession(signHash);
+        }
+
         // Remove sessions which timed out
         std::unordered_set<uint256> timeoutSessions;
         for (auto& p : firstSeenForSessions) {
@@ -957,20 +971,6 @@ void CSigSharesManager::Cleanup()
             RemoveSigSharesForSession(signHash);
         }
 
-        // Remove sessions which were successfully recovered
-        std::unordered_set<uint256> doneSessions;
-        sigShares.ForEach([&](const SigShareKey& k, const CSigShare& sigShare) {
-            if (doneSessions.count(sigShare.GetSignHash())) {
-                return;
-            }
-            if (quorumSigningManager->HasRecoveredSigForSession(sigShare.GetSignHash())) {
-                doneSessions.emplace(sigShare.GetSignHash());
-            }
-        });
-        for (auto& signHash : doneSessions) {
-            RemoveSigSharesForSession(signHash);
-        }
-
         sigShares.ForEach([&](const SigShareKey& k, const CSigShare& sigShare) {
             quorumsToCheck.emplace((Consensus::LLMQType)sigShare.llmqType, sigShare.quorumHash);
         });
